Skip to content

Commit b4722b8

Browse files
Baoquan Hehtejun
authored andcommitted
kernel/workqueue.c: fix DEFINE_PER_CPU_SHARED_ALIGNED expansion
Make tags always produces below annoying warnings: ctags: Warning: kernel/workqueue.c:470: null expansion of name pattern "\1" ctags: Warning: kernel/workqueue.c:474: null expansion of name pattern "\1" ctags: Warning: kernel/workqueue.c:478: null expansion of name pattern "\1" In commit 2552821 ("tags: Fix DEFINE_PER_CPU expansions"), codes in places have been adjusted including cpu_worker_pools definition. I noticed in commit 4cb1ef6 ("workqueue: Implement BH workqueues to eventually replace tasklets"), cpu_worker_pools definition was unfolded back. Not sure if it was intentionally done or ignored carelessly. Makes change to mute them specifically. Signed-off-by: Baoquan He <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent d156263 commit b4722b8

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

kernel/workqueue.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -477,16 +477,13 @@ static bool wq_debug_force_rr_cpu = false;
477477
module_param_named(debug_force_rr_cpu, wq_debug_force_rr_cpu, bool, 0644);
478478

479479
/* to raise softirq for the BH worker pools on other CPUs */
480-
static DEFINE_PER_CPU_SHARED_ALIGNED(struct irq_work [NR_STD_WORKER_POOLS],
481-
bh_pool_irq_works);
480+
static DEFINE_PER_CPU_SHARED_ALIGNED(struct irq_work [NR_STD_WORKER_POOLS], bh_pool_irq_works);
482481

483482
/* the BH worker pools */
484-
static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS],
485-
bh_worker_pools);
483+
static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS], bh_worker_pools);
486484

487485
/* the per-cpu worker pools */
488-
static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS],
489-
cpu_worker_pools);
486+
static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS], cpu_worker_pools);
490487

491488
static DEFINE_IDR(worker_pool_idr); /* PR: idr of all pools */
492489

0 commit comments

Comments
 (0)