Skip to content

Commit b4b797d

Browse files
Zhen Leitehcaster
authored andcommitted
mm/slab: remove duplicate check in create_cache()
The WARN_ON() check in static function create_cache() is done by its only parent __kmem_cache_create_args() before calling it. if (... || WARN_ON(... || object_size - args->usersize < args->useroffset)) args->usersize = args->useroffset = 0; ... s = create_cache(cache_name, object_size, args, flags); Therefore, the WARN_ON() check in create_cache() can be safely removed. Signed-off-by: Zhen Lei <[email protected]> Signed-off-by: Vlastimil Babka <[email protected]>
1 parent 1e4df18 commit b4b797d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

mm/slab_common.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,6 @@ static struct kmem_cache *create_cache(const char *name,
222222
struct kmem_cache *s;
223223
int err;
224224

225-
if (WARN_ON(args->useroffset + args->usersize > object_size))
226-
args->useroffset = args->usersize = 0;
227-
228225
/* If a custom freelist pointer is requested make sure it's sane. */
229226
err = -EINVAL;
230227
if (args->use_freeptr_offset &&

0 commit comments

Comments
 (0)