Skip to content

Commit b4e0f9a

Browse files
yuzibodavem330
authored andcommitted
mptcp/pm_netlink.c : add check for nla_put_in/6_addr
Normal there should be checked for nla_put_in6_addr like other usage in net. Detected by CoverityScan, CID# 1461639 Fixes: 01cacb0 ("mptcp: add netlink-based PM") Signed-off-by: Bo YU <[email protected]> Acked-by: Paolo Abeni <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 6ed79ce commit b4e0f9a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

net/mptcp/pm_netlink.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -599,12 +599,14 @@ static int mptcp_nl_fill_addr(struct sk_buff *skb,
599599
nla_put_s32(skb, MPTCP_PM_ADDR_ATTR_IF_IDX, entry->ifindex))
600600
goto nla_put_failure;
601601

602-
if (addr->family == AF_INET)
603-
nla_put_in_addr(skb, MPTCP_PM_ADDR_ATTR_ADDR4,
604-
addr->addr.s_addr);
602+
if (addr->family == AF_INET &&
603+
nla_put_in_addr(skb, MPTCP_PM_ADDR_ATTR_ADDR4,
604+
addr->addr.s_addr))
605+
goto nla_put_failure;
605606
#if IS_ENABLED(CONFIG_MPTCP_IPV6)
606-
else if (addr->family == AF_INET6)
607-
nla_put_in6_addr(skb, MPTCP_PM_ADDR_ATTR_ADDR6, &addr->addr6);
607+
else if (addr->family == AF_INET6 &&
608+
nla_put_in6_addr(skb, MPTCP_PM_ADDR_ATTR_ADDR6, &addr->addr6))
609+
goto nla_put_failure;
608610
#endif
609611
nla_nest_end(skb, attr);
610612
return 0;

0 commit comments

Comments
 (0)