Skip to content

Commit b4ed2c6

Browse files
yanzhao56bonzini
authored andcommitted
KVM: selftests: Test slot move/delete with slot zap quirk enabled/disabled
Update set_memory_region_test to make sure memslot move and deletion function correctly both when slot zap quirk KVM_X86_QUIRK_SLOT_ZAP_ALL is enabled and disabled. Signed-off-by: Yan Zhao <[email protected]> Message-ID: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent aa8d1f4 commit b4ed2c6

File tree

1 file changed

+21
-8
lines changed

1 file changed

+21
-8
lines changed

tools/testing/selftests/kvm/set_memory_region_test.c

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ static void guest_code_move_memory_region(void)
175175
GUEST_DONE();
176176
}
177177

178-
static void test_move_memory_region(void)
178+
static void test_move_memory_region(bool disable_slot_zap_quirk)
179179
{
180180
pthread_t vcpu_thread;
181181
struct kvm_vcpu *vcpu;
@@ -184,6 +184,9 @@ static void test_move_memory_region(void)
184184

185185
vm = spawn_vm(&vcpu, &vcpu_thread, guest_code_move_memory_region);
186186

187+
if (disable_slot_zap_quirk)
188+
vm_enable_cap(vm, KVM_CAP_DISABLE_QUIRKS2, KVM_X86_QUIRK_SLOT_ZAP_ALL);
189+
187190
hva = addr_gpa2hva(vm, MEM_REGION_GPA);
188191

189192
/*
@@ -266,7 +269,7 @@ static void guest_code_delete_memory_region(void)
266269
GUEST_ASSERT(0);
267270
}
268271

269-
static void test_delete_memory_region(void)
272+
static void test_delete_memory_region(bool disable_slot_zap_quirk)
270273
{
271274
pthread_t vcpu_thread;
272275
struct kvm_vcpu *vcpu;
@@ -276,6 +279,9 @@ static void test_delete_memory_region(void)
276279

277280
vm = spawn_vm(&vcpu, &vcpu_thread, guest_code_delete_memory_region);
278281

282+
if (disable_slot_zap_quirk)
283+
vm_enable_cap(vm, KVM_CAP_DISABLE_QUIRKS2, KVM_X86_QUIRK_SLOT_ZAP_ALL);
284+
279285
/* Delete the memory region, the guest should not die. */
280286
vm_mem_region_delete(vm, MEM_REGION_SLOT);
281287
wait_for_vcpu();
@@ -553,7 +559,10 @@ int main(int argc, char *argv[])
553559
{
554560
#ifdef __x86_64__
555561
int i, loops;
562+
int j, disable_slot_zap_quirk = 0;
556563

564+
if (kvm_check_cap(KVM_CAP_DISABLE_QUIRKS2) & KVM_X86_QUIRK_SLOT_ZAP_ALL)
565+
disable_slot_zap_quirk = 1;
557566
/*
558567
* FIXME: the zero-memslot test fails on aarch64 and s390x because
559568
* KVM_RUN fails with ENOEXEC or EFAULT.
@@ -579,13 +588,17 @@ int main(int argc, char *argv[])
579588
else
580589
loops = 10;
581590

582-
pr_info("Testing MOVE of in-use region, %d loops\n", loops);
583-
for (i = 0; i < loops; i++)
584-
test_move_memory_region();
591+
for (j = 0; j <= disable_slot_zap_quirk; j++) {
592+
pr_info("Testing MOVE of in-use region, %d loops, slot zap quirk %s\n",
593+
loops, j ? "disabled" : "enabled");
594+
for (i = 0; i < loops; i++)
595+
test_move_memory_region(!!j);
585596

586-
pr_info("Testing DELETE of in-use region, %d loops\n", loops);
587-
for (i = 0; i < loops; i++)
588-
test_delete_memory_region();
597+
pr_info("Testing DELETE of in-use region, %d loops, slot zap quirk %s\n",
598+
loops, j ? "disabled" : "enabled");
599+
for (i = 0; i < loops; i++)
600+
test_delete_memory_region(!!j);
601+
}
589602
#endif
590603

591604
return 0;

0 commit comments

Comments
 (0)