Skip to content

Commit b4edca1

Browse files
Jiri Slabysuryasaimadhu
authored andcommitted
x86/asm: Remove the last GLOBAL user and remove the macro
Convert the remaining 32bit users and remove the GLOBAL macro finally. In particular, this means to use SYM_ENTRY for the singlestepping hack region. Exclude the global definition of GLOBAL from x86 too. Signed-off-by: Jiri Slaby <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Andrey Ryabinin <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: "H. Peter Anvin" <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: [email protected] Cc: Mark Rutland <[email protected]> Cc: "Rafael J. Wysocki" <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Will Deacon <[email protected]> Cc: x86-ml <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 78f4433 commit b4edca1

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

arch/x86/entry/entry_32.S

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -832,7 +832,7 @@ SYM_INNER_LABEL_ALIGN(resume_userspace, SYM_L_LOCAL)
832832
jmp restore_all
833833
SYM_CODE_END(ret_from_exception)
834834

835-
GLOBAL(__begin_SYSENTER_singlestep_region)
835+
SYM_ENTRY(__begin_SYSENTER_singlestep_region, SYM_L_GLOBAL, SYM_A_NONE)
836836
/*
837837
* All code from here through __end_SYSENTER_singlestep_region is subject
838838
* to being single-stepped if a user program sets TF and executes SYSENTER.
@@ -1011,7 +1011,7 @@ ENTRY(entry_SYSENTER_32)
10111011
pushl $X86_EFLAGS_FIXED
10121012
popfl
10131013
jmp .Lsysenter_flags_fixed
1014-
GLOBAL(__end_SYSENTER_singlestep_region)
1014+
SYM_ENTRY(__end_SYSENTER_singlestep_region, SYM_L_GLOBAL, SYM_A_NONE)
10151015
ENDPROC(entry_SYSENTER_32)
10161016

10171017
/*

arch/x86/include/asm/linkage.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,6 @@
1313

1414
#ifdef __ASSEMBLY__
1515

16-
/*
17-
* GLOBAL is DEPRECATED
18-
*
19-
* use SYM_DATA_START, SYM_FUNC_START, SYM_INNER_LABEL, SYM_CODE_START, or
20-
* similar
21-
*/
22-
#define GLOBAL(name) SYM_ENTRY(name, SYM_L_GLOBAL, SYM_A_NONE)
23-
2416
#if defined(CONFIG_X86_64) || defined(CONFIG_X86_ALIGNMENT_16)
2517
#define __ALIGN .p2align 4, 0x90
2618
#define __ALIGN_STR __stringify(__ALIGN)

include/linux/linkage.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,14 @@
105105

106106
/* === DEPRECATED annotations === */
107107

108+
#ifndef CONFIG_X86
108109
#ifndef GLOBAL
109110
/* deprecated, use SYM_DATA*, SYM_ENTRY, or similar */
110111
#define GLOBAL(name) \
111112
.globl name ASM_NL \
112113
name:
113114
#endif
115+
#endif
114116

115117
#ifndef ENTRY
116118
/* deprecated, use SYM_FUNC_START */

0 commit comments

Comments
 (0)