Skip to content

Commit b503aef

Browse files
agarwalvaibhavgregkh
authored andcommitted
staging: greybus: audio: Update snd_jack FW usage as per new APIs
snd_soc_jack APIs are modified in recent kernel versions. This patch updates the codec driver to resolve the compilation errors related to jack framework. Signed-off-by: Vaibhav Agarwal <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/896b8e24d990f2bca5aafaebd26e37095042951e.1594290158.git.vaibhav.sr@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 2067fd9 commit b503aef

File tree

1 file changed

+42
-12
lines changed

1 file changed

+42
-12
lines changed

drivers/staging/greybus/audio_codec.c

Lines changed: 42 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -709,17 +709,26 @@ static struct snd_soc_dai_driver gbaudio_dai[] = {
709709
};
710710

711711
static int gbaudio_init_jack(struct gbaudio_module_info *module,
712-
struct snd_soc_codec *codec)
712+
struct snd_soc_card *card)
713713
{
714714
int ret;
715+
struct snd_soc_jack_pin *headset, *button;
715716

716717
if (!module->jack_mask)
717718
return 0;
718719

719720
snprintf(module->jack_name, NAME_SIZE, "GB %d Headset Jack",
720721
module->dev_id);
721-
ret = snd_soc_jack_new(codec, module->jack_name, module->jack_mask,
722-
&module->headset_jack);
722+
723+
headset = devm_kzalloc(module->dev, sizeof(*headset), GFP_KERNEL);
724+
if (!headset)
725+
return -ENOMEM;
726+
727+
headset->pin = module->jack_name;
728+
headset->mask = module->jack_mask;
729+
730+
ret = snd_soc_card_jack_new(card, module->jack_name, module->jack_mask,
731+
&module->headset_jack, headset, 1);
723732
if (ret) {
724733
dev_err(module->dev, "Failed to create new jack\n");
725734
return ret;
@@ -730,11 +739,21 @@ static int gbaudio_init_jack(struct gbaudio_module_info *module,
730739

731740
snprintf(module->button_name, NAME_SIZE, "GB %d Button Jack",
732741
module->dev_id);
733-
ret = snd_soc_jack_new(codec, module->button_name, module->button_mask,
734-
&module->button_jack);
742+
button = devm_kzalloc(module->dev, sizeof(*button), GFP_KERNEL);
743+
if (!button) {
744+
ret = -ENOMEM;
745+
goto free_headset;
746+
}
747+
748+
button->pin = module->button_name;
749+
button->mask = module->button_mask;
750+
751+
ret = snd_soc_card_jack_new(card, module->button_name,
752+
module->button_mask, &module->button_jack,
753+
button, 1);
735754
if (ret) {
736755
dev_err(module->dev, "Failed to create button jack\n");
737-
return ret;
756+
goto free_headset;
738757
}
739758

740759
/*
@@ -750,7 +769,7 @@ static int gbaudio_init_jack(struct gbaudio_module_info *module,
750769
KEY_MEDIA);
751770
if (ret) {
752771
dev_err(module->dev, "Failed to set BTN_0\n");
753-
return ret;
772+
goto free_button;
754773
}
755774
}
756775

@@ -759,7 +778,7 @@ static int gbaudio_init_jack(struct gbaudio_module_info *module,
759778
KEY_VOICECOMMAND);
760779
if (ret) {
761780
dev_err(module->dev, "Failed to set BTN_1\n");
762-
return ret;
781+
goto free_button;
763782
}
764783
}
765784

@@ -768,7 +787,7 @@ static int gbaudio_init_jack(struct gbaudio_module_info *module,
768787
KEY_VOLUMEUP);
769788
if (ret) {
770789
dev_err(module->dev, "Failed to set BTN_2\n");
771-
return ret;
790+
goto free_button;
772791
}
773792
}
774793

@@ -777,7 +796,7 @@ static int gbaudio_init_jack(struct gbaudio_module_info *module,
777796
KEY_VOLUMEDOWN);
778797
if (ret) {
779798
dev_err(module->dev, "Failed to set BTN_0\n");
780-
return ret;
799+
goto free_button;
781800
}
782801
}
783802

@@ -788,6 +807,16 @@ static int gbaudio_init_jack(struct gbaudio_module_info *module,
788807
*/
789808

790809
return 0;
810+
811+
free_button:
812+
snd_device_free(card->snd_card, module->button_jack.jack);
813+
list_del(&module->button_jack.list);
814+
815+
free_headset:
816+
snd_device_free(card->snd_card, module->headset_jack.jack);
817+
list_del(&module->headset_jack.list);
818+
819+
return ret;
791820
}
792821

793822
int gbaudio_register_module(struct gbaudio_module_info *module)
@@ -815,7 +844,7 @@ int gbaudio_register_module(struct gbaudio_module_info *module)
815844
return -EINVAL;
816845
}
817846

818-
ret = gbaudio_init_jack(module, codec);
847+
ret = gbaudio_init_jack(module, component->card);
819848
if (ret) {
820849
up_write(&card->controls_rwsem);
821850
return ret;
@@ -942,7 +971,8 @@ void gbaudio_unregister_module(struct gbaudio_module_info *module)
942971

943972
#ifdef CONFIG_SND_JACK
944973
/* free jack devices for this module from codec->jack_list */
945-
list_for_each_entry_safe(jack, next_j, &codec->jack_list, list) {
974+
list_for_each_entry_safe(jack, next_j, &component->card->jack_list,
975+
list) {
946976
if (jack == &module->headset_jack)
947977
mask = GBCODEC_JACK_MASK;
948978
else if (jack == &module->button_jack)

0 commit comments

Comments
 (0)