Skip to content

Commit b582d5f

Browse files
author
Andreas Gruenbacher
committed
gfs2: Mark flock glock holders as GL_NOPID
Add the GL_NOPID flag for flock glock holders. Clean up the flag setting code in do_flock. Signed-off-by: Andreas Gruenbacher <[email protected]>
1 parent cbe6d25 commit b582d5f

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

fs/gfs2/file.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1472,7 +1472,9 @@ static int do_flock(struct file *file, int cmd, struct file_lock *fl)
14721472
int sleeptime;
14731473

14741474
state = (fl->fl_type == F_WRLCK) ? LM_ST_EXCLUSIVE : LM_ST_SHARED;
1475-
flags = (IS_SETLKW(cmd) ? 0 : LM_FLAG_TRY_1CB) | GL_EXACT;
1475+
flags = GL_EXACT | GL_NOPID;
1476+
if (!IS_SETLKW(cmd))
1477+
flags |= LM_FLAG_TRY_1CB;
14761478

14771479
mutex_lock(&fp->f_fl_mutex);
14781480

@@ -1500,7 +1502,8 @@ static int do_flock(struct file *file, int cmd, struct file_lock *fl)
15001502
error = gfs2_glock_nq(fl_gh);
15011503
if (error != GLR_TRYFAILED)
15021504
break;
1503-
fl_gh->gh_flags = LM_FLAG_TRY | GL_EXACT;
1505+
fl_gh->gh_flags &= ~LM_FLAG_TRY_1CB;
1506+
fl_gh->gh_flags |= LM_FLAG_TRY;
15041507
msleep(sleeptime);
15051508
}
15061509
if (error) {

0 commit comments

Comments
 (0)