Skip to content

Commit b5ec398

Browse files
andy-shevbroonie
authored andcommitted
spi: pxa2xx: Don't provide struct chip_data for others
Now the struct chip_data is local to spi-pxa2xx.c, move its definition to the C file. This will slightly speed up a build and also hide badly named data type (too generic). Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 35bf074 commit b5ec398

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

drivers/spi/spi-pxa2xx.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,14 @@ MODULE_ALIAS("platform:pxa2xx-spi");
6666
| CE4100_SSCR1_RFT | CE4100_SSCR1_TFT | SSCR1_MWDS \
6767
| SSCR1_SPH | SSCR1_SPO | SSCR1_LBM)
6868

69+
struct chip_data {
70+
u32 cr1;
71+
u32 dds_rate;
72+
u32 threshold;
73+
u16 lpss_rx_threshold;
74+
u16 lpss_tx_threshold;
75+
};
76+
6977
#define LPSS_GENERAL_REG_RXTO_HOLDOFF_DISABLE BIT(24)
7078
#define LPSS_CS_CONTROL_SW_MODE BIT(0)
7179
#define LPSS_CS_CONTROL_CS_HIGH BIT(1)

drivers/spi/spi-pxa2xx.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,6 @@ struct driver_data {
7575
struct gpio_desc *gpiod_ready;
7676
};
7777

78-
struct chip_data {
79-
u32 cr1;
80-
u32 dds_rate;
81-
u32 threshold;
82-
u16 lpss_rx_threshold;
83-
u16 lpss_tx_threshold;
84-
};
85-
8678
static inline u32 pxa2xx_spi_read(const struct driver_data *drv_data, u32 reg)
8779
{
8880
return pxa_ssp_read_reg(drv_data->ssp, reg);

0 commit comments

Comments
 (0)