Skip to content

Commit b67b7b0

Browse files
simransinghalgregkh
authored andcommitted
staging: rtl8723bs: hal: Remove NULL check before kfree
NULL check before kfree is unnecessary so remove it. The following Coccinelle script was used to detect this: @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; Signed-off-by: Simran Singhal <[email protected]> Link: https://lore.kernel.org/r/20200326132823.GA18625@simran-Inspiron-5558 Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 1879d30 commit b67b7b0

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -480,10 +480,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
480480
precvpriv->precv_buf = NULL;
481481
}
482482

483-
if (precvpriv->pallocated_recv_buf) {
484-
kfree(precvpriv->pallocated_recv_buf);
485-
precvpriv->pallocated_recv_buf = NULL;
486-
}
483+
kfree(precvpriv->pallocated_recv_buf);
484+
precvpriv->pallocated_recv_buf = NULL;
487485

488486
exit:
489487
return res;
@@ -518,8 +516,6 @@ void rtl8723bs_free_recv_priv(struct adapter *padapter)
518516
precvpriv->precv_buf = NULL;
519517
}
520518

521-
if (precvpriv->pallocated_recv_buf) {
522-
kfree(precvpriv->pallocated_recv_buf);
523-
precvpriv->pallocated_recv_buf = NULL;
524-
}
519+
kfree(precvpriv->pallocated_recv_buf);
520+
precvpriv->pallocated_recv_buf = NULL;
525521
}

0 commit comments

Comments
 (0)