Skip to content

Commit b6890ef

Browse files
vizhaoalexdeucher
authored andcommitted
drm/amdkfd: remove extra use of volatile
as the adding of mb() should be sufficient in function unmap_queues_cpsch, remove the add of volatile type as recommended Signed-off-by: Victor Zhao <[email protected]> Reviewed-by: Christian König <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 3d0ffc6 commit b6890ef

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2048,7 +2048,7 @@ int amdkfd_fence_wait_timeout(struct device_queue_manager *dqm,
20482048
{
20492049
unsigned long end_jiffies = msecs_to_jiffies(timeout_ms) + jiffies;
20502050
struct device *dev = dqm->dev->adev->dev;
2051-
volatile uint64_t *fence_addr = dqm->fence_addr;
2051+
uint64_t *fence_addr = dqm->fence_addr;
20522052

20532053
while (*fence_addr != fence_value) {
20542054
/* Fatal err detected, this response won't come */

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ struct device_queue_manager {
260260
uint16_t vmid_pasid[VMID_NUM];
261261
uint64_t pipelines_addr;
262262
uint64_t fence_gpu_addr;
263-
volatile uint64_t *fence_addr;
263+
uint64_t *fence_addr;
264264
struct kfd_mem_obj *fence_mem;
265265
bool active_runlist;
266266
int sched_policy;

0 commit comments

Comments
 (0)