Skip to content

Commit b6bcd1c

Browse files
arndbandersson
authored andcommitted
clk: qcom: fix some Kconfig corner cases
The SM_GCC_8550 symbol and others can only be built for ARM64 or when compile testing, but it gets selected by other drivers that can also be built for 32-bit ARCH_QCOM when not compile testing, which results in a Kconfig warning: WARNING: unmet direct dependencies detected for SM_GCC_8550 Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n]) Selected by [m]: - SM_GPUCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] - SM_VIDEOCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] Add further 'depends on' statements to tighten this in a way that avoids the missing dependencies. Fixes: fd0b5b1 ("clk: qcom: Introduce SM8350 VIDEOCC") Fixes: 441fe71 ("clk: qcom: videocc-sm8450: Add video clock controller driver for SM8450") Fixes: f53153a ("clk: qcom: videocc-sm8550: Add video clock controller driver for SM8550") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 783cb69 commit b6bcd1c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/clk/qcom/Kconfig

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -986,6 +986,7 @@ config SM_GPUCC_8450
986986

987987
config SM_GPUCC_8550
988988
tristate "SM8550 Graphics Clock Controller"
989+
depends on ARM64 || COMPILE_TEST
989990
select SM_GCC_8550
990991
help
991992
Support for the graphics clock controller on SM8550 devices.
@@ -1022,6 +1023,7 @@ config SM_VIDEOCC_8250
10221023

10231024
config SM_VIDEOCC_8350
10241025
tristate "SM8350 Video Clock Controller"
1026+
depends on ARM64 || COMPILE_TEST
10251027
select SM_GCC_8350
10261028
select QCOM_GDSC
10271029
help
@@ -1031,6 +1033,7 @@ config SM_VIDEOCC_8350
10311033

10321034
config SM_VIDEOCC_8550
10331035
tristate "SM8550 Video Clock Controller"
1036+
depends on ARM64 || COMPILE_TEST
10341037
select SM_GCC_8550
10351038
select QCOM_GDSC
10361039
help
@@ -1079,6 +1082,7 @@ config CLK_GFM_LPASS_SM8250
10791082

10801083
config SM_VIDEOCC_8450
10811084
tristate "SM8450 Video Clock Controller"
1085+
depends on ARM64 || COMPILE_TEST
10821086
select SM_GCC_8450
10831087
select QCOM_GDSC
10841088
help

0 commit comments

Comments
 (0)