Skip to content

Commit b6ddaa6

Browse files
harshimogalapallimmind
authored andcommitted
drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable()
Unlock before returning on the error path. Fixes: 5a028e8 ("drm/rockchip: vop2: Add support for rk3588") Signed-off-by: Harshit Mogalapalli <[email protected]> Reviewed-by: Sascha Hauer <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent b6802b6 commit b6ddaa6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1985,8 +1985,10 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
19851985
clock = vop2_set_intf_mux(vp, rkencoder->crtc_endpoint_id, polflags);
19861986
}
19871987

1988-
if (!clock)
1988+
if (!clock) {
1989+
vop2_unlock(vop2);
19891990
return;
1991+
}
19901992

19911993
if (vcstate->output_mode == ROCKCHIP_OUT_MODE_AAAA &&
19921994
!(vp_data->feature & VOP2_VP_FEATURE_OUTPUT_10BIT))

0 commit comments

Comments
 (0)