Skip to content

Commit b6f91ab

Browse files
committed
Merge tag 'tpmdd-next-20200522' of git://git.infradead.org/users/jjs/linux-tpmdd
Pull tpm updates from Jarkko Sakkinen. * tag 'tpmdd-next-20200522' of git://git.infradead.org/users/jjs/linux-tpmdd: tpm: eventlog: Replace zero-length array with flexible-array member tpm/tpm_ftpm_tee: Use UUID API for exporting the UUID
2 parents 3d77e6a + ab91c2a commit b6f91ab

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

drivers/char/tpm/eventlog/tpm2.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ static void *tpm2_bios_measurements_start(struct seq_file *m, loff_t *pos)
5151
int i;
5252

5353
event_header = addr;
54-
size = sizeof(struct tcg_pcr_event) - sizeof(event_header->event)
55-
+ event_header->event_size;
54+
size = struct_size(event_header, event, event_header->event_size);
5655

5756
if (*pos == 0) {
5857
if (addr + size < limit) {
@@ -98,8 +97,8 @@ static void *tpm2_bios_measurements_next(struct seq_file *m, void *v,
9897
event_header = log->bios_event_log;
9998

10099
if (v == SEQ_START_TOKEN) {
101-
event_size = sizeof(struct tcg_pcr_event) -
102-
sizeof(event_header->event) + event_header->event_size;
100+
event_size = struct_size(event_header, event,
101+
event_header->event_size);
103102
marker = event_header;
104103
} else {
105104
event = v;
@@ -136,9 +135,8 @@ static int tpm2_binary_bios_measurements_show(struct seq_file *m, void *v)
136135
size_t size;
137136

138137
if (v == SEQ_START_TOKEN) {
139-
size = sizeof(struct tcg_pcr_event) -
140-
sizeof(event_header->event) + event_header->event_size;
141-
138+
size = struct_size(event_header, event,
139+
event_header->event_size);
142140
temp_ptr = event_header;
143141

144142
if (size > 0)

drivers/char/tpm/tpm_ftpm_tee.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ static int ftpm_tee_probe(struct platform_device *pdev)
241241

242242
/* Open a session with fTPM TA */
243243
memset(&sess_arg, 0, sizeof(sess_arg));
244-
memcpy(sess_arg.uuid, ftpm_ta_uuid.b, TEE_IOCTL_UUID_LEN);
244+
export_uuid(sess_arg.uuid, &ftpm_ta_uuid);
245245
sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
246246
sess_arg.num_params = 0;
247247

include/linux/tpm_eventlog.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ struct tcg_pcr_event {
9797
u32 event_type;
9898
u8 digest[20];
9999
u32 event_size;
100-
u8 event[0];
100+
u8 event[];
101101
} __packed;
102102

103103
struct tcg_event_field {

0 commit comments

Comments
 (0)