Skip to content

Commit b70c799

Browse files
cris-masudeep-holla
authored andcommitted
firmware: arm_scmi: Make raw debugfs entries non-seekable
SCMI raw debugfs entries are used to inject and snoop messages out of the SCMI core and, as such, the underlying virtual files have no reason to support seeking. Modify the related file_operations descriptors to be non-seekable. Fixes: 3c3d818 ("firmware: arm_scmi: Add core raw transmission support") Signed-off-by: Cristian Marussi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sudeep Holla <[email protected]>
1 parent 17f243a commit b70c799

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/firmware/arm_scmi/raw_mode.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -921,7 +921,7 @@ static int scmi_dbg_raw_mode_open(struct inode *inode, struct file *filp)
921921
rd->raw = raw;
922922
filp->private_data = rd;
923923

924-
return 0;
924+
return nonseekable_open(inode, filp);
925925
}
926926

927927
static int scmi_dbg_raw_mode_release(struct inode *inode, struct file *filp)
@@ -950,6 +950,7 @@ static const struct file_operations scmi_dbg_raw_mode_reset_fops = {
950950
.open = scmi_dbg_raw_mode_open,
951951
.release = scmi_dbg_raw_mode_release,
952952
.write = scmi_dbg_raw_mode_reset_write,
953+
.llseek = no_llseek,
953954
.owner = THIS_MODULE,
954955
};
955956

@@ -959,6 +960,7 @@ static const struct file_operations scmi_dbg_raw_mode_message_fops = {
959960
.read = scmi_dbg_raw_mode_message_read,
960961
.write = scmi_dbg_raw_mode_message_write,
961962
.poll = scmi_dbg_raw_mode_message_poll,
963+
.llseek = no_llseek,
962964
.owner = THIS_MODULE,
963965
};
964966

@@ -975,6 +977,7 @@ static const struct file_operations scmi_dbg_raw_mode_message_async_fops = {
975977
.read = scmi_dbg_raw_mode_message_read,
976978
.write = scmi_dbg_raw_mode_message_async_write,
977979
.poll = scmi_dbg_raw_mode_message_poll,
980+
.llseek = no_llseek,
978981
.owner = THIS_MODULE,
979982
};
980983

@@ -998,6 +1001,7 @@ static const struct file_operations scmi_dbg_raw_mode_notification_fops = {
9981001
.release = scmi_dbg_raw_mode_release,
9991002
.read = scmi_test_dbg_raw_mode_notif_read,
10001003
.poll = scmi_test_dbg_raw_mode_notif_poll,
1004+
.llseek = no_llseek,
10011005
.owner = THIS_MODULE,
10021006
};
10031007

@@ -1021,6 +1025,7 @@ static const struct file_operations scmi_dbg_raw_mode_errors_fops = {
10211025
.release = scmi_dbg_raw_mode_release,
10221026
.read = scmi_test_dbg_raw_mode_errors_read,
10231027
.poll = scmi_test_dbg_raw_mode_errors_poll,
1028+
.llseek = no_llseek,
10241029
.owner = THIS_MODULE,
10251030
};
10261031

0 commit comments

Comments
 (0)