Skip to content

Commit b727db9

Browse files
krzkLee Jones
authored andcommitted
dt-bindings: mfd: Correct interrupt flags in examples
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW Signed-off-by: Krzysztof Kozlowski <[email protected]> Acked-by: Matti Vaittinen <[email protected]> # for BD70528 Acked-by: Tim Harvey <[email protected]> # for gateworks-gsc.yaml Acked-by: Rob Herring <[email protected]> Signed-off-by: Lee Jones <[email protected]>
1 parent e8299c7 commit b727db9

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

Documentation/devicetree/bindings/mfd/act8945a.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ Example:
7171
pinctrl-names = "default";
7272
pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
7373
interrupt-parent = <&pioA>;
74-
interrupts = <45 GPIO_ACTIVE_LOW>;
74+
interrupts = <45 IRQ_TYPE_LEVEL_LOW>;
7575

7676
active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
7777
active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;

Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ required:
147147
examples:
148148
- |
149149
#include <dt-bindings/gpio/gpio.h>
150+
#include <dt-bindings/interrupt-controller/irq.h>
150151
i2c {
151152
#address-cells = <1>;
152153
#size-cells = <0>;
@@ -155,7 +156,7 @@ examples:
155156
compatible = "gw,gsc";
156157
reg = <0x20>;
157158
interrupt-parent = <&gpio1>;
158-
interrupts = <4 GPIO_ACTIVE_LOW>;
159+
interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
159160
interrupt-controller;
160161
#interrupt-cells = <1>;
161162
#address-cells = <1>;

Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ pmic: pmic@4b {
3939
compatible = "rohm,bd70528";
4040
reg = <0x4b>;
4141
interrupt-parent = <&gpio1>;
42-
interrupts = <29 GPIO_ACTIVE_LOW>;
42+
interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
4343
clocks = <&osc 0>;
4444
#clock-cells = <0>;
4545
clock-output-names = "bd70528-32k-out";

0 commit comments

Comments
 (0)