Skip to content

Commit b757eb0

Browse files
Wolfram SangAndi Shyti
authored andcommitted
i2c: i801: remove printout on handled timeouts
I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout and turn the SMBus-specific termination message to debug. Signed-off-by: Wolfram Sang <[email protected]> Reviewed-by: Jean Delvare <[email protected]> Signed-off-by: Andi Shyti <[email protected]>
1 parent a06b80e commit b757eb0

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/i2c/busses/i2c-i801.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -399,9 +399,7 @@ static int i801_check_post(struct i801_priv *priv, int status)
399399
* If the SMBus is still busy, we give up
400400
*/
401401
if (unlikely(status < 0)) {
402-
dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
403402
/* try to stop the current command */
404-
dev_dbg(&priv->pci_dev->dev, "Terminating the current operation\n");
405403
outb_p(SMBHSTCNT_KILL, SMBHSTCNT(priv));
406404
usleep_range(1000, 2000);
407405
outb_p(0, SMBHSTCNT(priv));
@@ -410,7 +408,7 @@ static int i801_check_post(struct i801_priv *priv, int status)
410408
status = inb_p(SMBHSTSTS(priv));
411409
if ((status & SMBHSTSTS_HOST_BUSY) ||
412410
!(status & SMBHSTSTS_FAILED))
413-
dev_err(&priv->pci_dev->dev,
411+
dev_dbg(&priv->pci_dev->dev,
414412
"Failed terminating the transaction\n");
415413
return -ETIMEDOUT;
416414
}

0 commit comments

Comments
 (0)