Skip to content

Commit b78fc1c

Browse files
committed
drm/bridge: Change parameter name of drm_atomic_bridge_chain_pre_enable()
drm_atomic_bridge_chain_pre_enable() enables all bridges affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent ba94ce1 commit b78fc1c

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/gpu/drm/drm_bridge.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -678,10 +678,10 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge,
678678
EXPORT_SYMBOL(drm_atomic_bridge_chain_post_disable);
679679

680680
static void drm_atomic_bridge_call_pre_enable(struct drm_bridge *bridge,
681-
struct drm_atomic_state *old_state)
681+
struct drm_atomic_state *state)
682682
{
683-
if (old_state && bridge->funcs->atomic_pre_enable)
684-
bridge->funcs->atomic_pre_enable(bridge, old_state);
683+
if (state && bridge->funcs->atomic_pre_enable)
684+
bridge->funcs->atomic_pre_enable(bridge, state);
685685
else if (bridge->funcs->pre_enable)
686686
bridge->funcs->pre_enable(bridge);
687687
}
@@ -690,7 +690,7 @@ static void drm_atomic_bridge_call_pre_enable(struct drm_bridge *bridge,
690690
* drm_atomic_bridge_chain_pre_enable - prepares for enabling all bridges in
691691
* the encoder chain
692692
* @bridge: bridge control structure
693-
* @old_state: old atomic state
693+
* @state: atomic state being committed
694694
*
695695
* Calls &drm_bridge_funcs.atomic_pre_enable (falls back on
696696
* &drm_bridge_funcs.pre_enable) op for all the bridges in the encoder chain,
@@ -710,7 +710,7 @@ static void drm_atomic_bridge_call_pre_enable(struct drm_bridge *bridge,
710710
* Note: the bridge passed should be the one closest to the encoder
711711
*/
712712
void drm_atomic_bridge_chain_pre_enable(struct drm_bridge *bridge,
713-
struct drm_atomic_state *old_state)
713+
struct drm_atomic_state *state)
714714
{
715715
struct drm_encoder *encoder;
716716
struct drm_bridge *iter, *next, *limit;
@@ -749,11 +749,11 @@ void drm_atomic_bridge_chain_pre_enable(struct drm_bridge *bridge,
749749
*/
750750
break;
751751

752-
drm_atomic_bridge_call_pre_enable(next, old_state);
752+
drm_atomic_bridge_call_pre_enable(next, state);
753753
}
754754
}
755755

756-
drm_atomic_bridge_call_pre_enable(iter, old_state);
756+
drm_atomic_bridge_call_pre_enable(iter, state);
757757

758758
if (iter->pre_enable_prev_first)
759759
/* Jump all bridges that we have already pre_enabled */

0 commit comments

Comments
 (0)