backlight: sky81452-backlight: Fix refcount imbalance on error

dinghaoliu · Lee Jones · commit b7a4f80bc316 · 2020-08-28T10:25:54.000+01:00
When of_property_read_u32_array() returns an error code, a pairing refcount decrement is needed to keep np's refcount balanced. Fixes: f705806 ("backlight: Add support Skyworks SKY81452 backlight driver") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
@@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
 					num_entry);
 		if (ret < 0) {
 			dev_err(dev, "led-sources node is invalid.\n");
+			of_node_put(np);
 			return ERR_PTR(-EINVAL);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(`
`217`	`217`	`num_entry);`
`218`	`218`	`if (ret < 0) {`
`219`	`219`	`dev_err(dev, "led-sources node is invalid.\n");`
	`220`	`+ of_node_put(np);`
`220`	`221`	`return ERR_PTR(-EINVAL);`
`221`	`222`	`}`
`222`	`223`