Skip to content

Commit b7d02c3

Browse files
committed
drm/i915: Pass intel_encoder to enc_to_*()
Lots of enc_to_foo(&encoder->base) around. Simplify by passing in the intel_encoder instead. @find@ identifier F =~ "^enc_to_.*"; identifier E; @@ F(struct drm_encoder *E) { ... } @@ identifier find.F; identifier find.E; @@ F( - struct drm_encoder *E + struct intel_encoder *encoder ) { <... - E + &encoder->base ...> } @@ identifier find.F; expression E; @@ - F(E) + F(to_intel_encoder(E)) @@ expression E; @@ - to_intel_encoder(&E->base) + E Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Juha-Pekka Heikkila <[email protected]>
1 parent 43a6d19 commit b7d02c3

22 files changed

+217
-212
lines changed

drivers/gpu/drm/i915/display/icl_dsi.c

Lines changed: 31 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ static enum transcoder dsi_port_to_transcoder(enum port port)
7777
static void wait_for_cmds_dispatched_to_panel(struct intel_encoder *encoder)
7878
{
7979
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
80-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
80+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
8181
struct mipi_dsi_device *dsi;
8282
enum port port;
8383
enum transcoder dsi_trans;
@@ -202,7 +202,7 @@ static int dsi_send_pkt_payld(struct intel_dsi_host *host,
202202
static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
203203
{
204204
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
205-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
205+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
206206
enum phy phy;
207207
u32 tmp;
208208
int lane;
@@ -267,7 +267,7 @@ static void configure_dual_link_mode(struct intel_encoder *encoder,
267267
const struct intel_crtc_state *pipe_config)
268268
{
269269
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
270-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
270+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
271271
u32 dss_ctl1;
272272

273273
dss_ctl1 = I915_READ(DSS_CTL1);
@@ -306,7 +306,7 @@ static void configure_dual_link_mode(struct intel_encoder *encoder,
306306
static int afe_clk(struct intel_encoder *encoder,
307307
const struct intel_crtc_state *crtc_state)
308308
{
309-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
309+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
310310
int bpp;
311311

312312
if (crtc_state->dsc.compression_enable)
@@ -321,7 +321,7 @@ static void gen11_dsi_program_esc_clk_div(struct intel_encoder *encoder,
321321
const struct intel_crtc_state *crtc_state)
322322
{
323323
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
324-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
324+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
325325
enum port port;
326326
int afe_clk_khz;
327327
u32 esc_clk_div_m;
@@ -360,7 +360,7 @@ static void get_dsi_io_power_domains(struct drm_i915_private *dev_priv,
360360
static void gen11_dsi_enable_io_power(struct intel_encoder *encoder)
361361
{
362362
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
363-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
363+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
364364
enum port port;
365365
u32 tmp;
366366

@@ -376,7 +376,7 @@ static void gen11_dsi_enable_io_power(struct intel_encoder *encoder)
376376
static void gen11_dsi_power_up_lanes(struct intel_encoder *encoder)
377377
{
378378
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
379-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
379+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
380380
enum phy phy;
381381

382382
for_each_dsi_phy(phy, intel_dsi->phys)
@@ -387,7 +387,7 @@ static void gen11_dsi_power_up_lanes(struct intel_encoder *encoder)
387387
static void gen11_dsi_config_phy_lanes_sequence(struct intel_encoder *encoder)
388388
{
389389
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
390-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
390+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
391391
enum phy phy;
392392
u32 tmp;
393393
int lane;
@@ -436,7 +436,7 @@ static void gen11_dsi_config_phy_lanes_sequence(struct intel_encoder *encoder)
436436
static void gen11_dsi_voltage_swing_program_seq(struct intel_encoder *encoder)
437437
{
438438
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
439-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
439+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
440440
u32 tmp;
441441
enum phy phy;
442442

@@ -488,7 +488,7 @@ static void gen11_dsi_voltage_swing_program_seq(struct intel_encoder *encoder)
488488
static void gen11_dsi_enable_ddi_buffer(struct intel_encoder *encoder)
489489
{
490490
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
491-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
491+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
492492
u32 tmp;
493493
enum port port;
494494

@@ -509,7 +509,7 @@ gen11_dsi_setup_dphy_timings(struct intel_encoder *encoder,
509509
const struct intel_crtc_state *crtc_state)
510510
{
511511
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
512-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
512+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
513513
u32 tmp;
514514
enum port port;
515515
enum phy phy;
@@ -575,7 +575,7 @@ gen11_dsi_setup_dphy_timings(struct intel_encoder *encoder,
575575
static void gen11_dsi_gate_clocks(struct intel_encoder *encoder)
576576
{
577577
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
578-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
578+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
579579
u32 tmp;
580580
enum phy phy;
581581

@@ -591,7 +591,7 @@ static void gen11_dsi_gate_clocks(struct intel_encoder *encoder)
591591
static void gen11_dsi_ungate_clocks(struct intel_encoder *encoder)
592592
{
593593
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
594-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
594+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
595595
u32 tmp;
596596
enum phy phy;
597597

@@ -608,7 +608,7 @@ static void gen11_dsi_map_pll(struct intel_encoder *encoder,
608608
const struct intel_crtc_state *crtc_state)
609609
{
610610
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
611-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
611+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
612612
struct intel_shared_dpll *pll = crtc_state->shared_dpll;
613613
enum phy phy;
614614
u32 val;
@@ -640,7 +640,7 @@ gen11_dsi_configure_transcoder(struct intel_encoder *encoder,
640640
const struct intel_crtc_state *pipe_config)
641641
{
642642
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
643-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
643+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
644644
struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->uapi.crtc);
645645
enum pipe pipe = intel_crtc->pipe;
646646
u32 tmp;
@@ -789,7 +789,7 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder,
789789
const struct intel_crtc_state *crtc_state)
790790
{
791791
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
792-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
792+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
793793
const struct drm_display_mode *adjusted_mode =
794794
&crtc_state->hw.adjusted_mode;
795795
enum port port;
@@ -923,7 +923,7 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder,
923923
static void gen11_dsi_enable_transcoder(struct intel_encoder *encoder)
924924
{
925925
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
926-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
926+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
927927
enum port port;
928928
enum transcoder dsi_trans;
929929
u32 tmp;
@@ -945,7 +945,7 @@ static void gen11_dsi_setup_timeouts(struct intel_encoder *encoder,
945945
const struct intel_crtc_state *crtc_state)
946946
{
947947
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
948-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
948+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
949949
enum port port;
950950
enum transcoder dsi_trans;
951951
u32 tmp, hs_tx_timeout, lp_rx_timeout, ta_timeout, divisor, mul;
@@ -1026,7 +1026,7 @@ gen11_dsi_enable_port_and_phy(struct intel_encoder *encoder,
10261026
static void gen11_dsi_powerup_panel(struct intel_encoder *encoder)
10271027
{
10281028
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1029-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1029+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
10301030
struct mipi_dsi_device *dsi;
10311031
enum port port;
10321032
enum transcoder dsi_trans;
@@ -1077,7 +1077,7 @@ static void gen11_dsi_pre_enable(struct intel_encoder *encoder,
10771077
const struct intel_crtc_state *pipe_config,
10781078
const struct drm_connector_state *conn_state)
10791079
{
1080-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1080+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
10811081

10821082
/* step3b */
10831083
gen11_dsi_map_pll(encoder, pipe_config);
@@ -1104,7 +1104,7 @@ static void gen11_dsi_pre_enable(struct intel_encoder *encoder,
11041104
static void gen11_dsi_disable_transcoder(struct intel_encoder *encoder)
11051105
{
11061106
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1107-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1107+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
11081108
enum port port;
11091109
enum transcoder dsi_trans;
11101110
u32 tmp;
@@ -1126,7 +1126,7 @@ static void gen11_dsi_disable_transcoder(struct intel_encoder *encoder)
11261126

11271127
static void gen11_dsi_powerdown_panel(struct intel_encoder *encoder)
11281128
{
1129-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1129+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
11301130

11311131
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DISPLAY_OFF);
11321132
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_ASSERT_RESET);
@@ -1139,7 +1139,7 @@ static void gen11_dsi_powerdown_panel(struct intel_encoder *encoder)
11391139
static void gen11_dsi_deconfigure_trancoder(struct intel_encoder *encoder)
11401140
{
11411141
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1142-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1142+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
11431143
enum port port;
11441144
enum transcoder dsi_trans;
11451145
u32 tmp;
@@ -1180,7 +1180,7 @@ static void gen11_dsi_deconfigure_trancoder(struct intel_encoder *encoder)
11801180
static void gen11_dsi_disable_port(struct intel_encoder *encoder)
11811181
{
11821182
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1183-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1183+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
11841184
u32 tmp;
11851185
enum port port;
11861186

@@ -1202,7 +1202,7 @@ static void gen11_dsi_disable_port(struct intel_encoder *encoder)
12021202
static void gen11_dsi_disable_io_power(struct intel_encoder *encoder)
12031203
{
12041204
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1205-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1205+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
12061206
enum port port;
12071207
u32 tmp;
12081208

@@ -1229,7 +1229,7 @@ static void gen11_dsi_disable(struct intel_encoder *encoder,
12291229
const struct intel_crtc_state *old_crtc_state,
12301230
const struct drm_connector_state *old_conn_state)
12311231
{
1232-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1232+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
12331233

12341234
/* step1: turn off backlight */
12351235
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_OFF);
@@ -1272,7 +1272,7 @@ static enum drm_mode_status gen11_dsi_mode_valid(struct drm_connector *connector
12721272
static void gen11_dsi_get_timings(struct intel_encoder *encoder,
12731273
struct intel_crtc_state *pipe_config)
12741274
{
1275-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1275+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
12761276
struct drm_display_mode *adjusted_mode =
12771277
&pipe_config->hw.adjusted_mode;
12781278

@@ -1313,7 +1313,7 @@ static void gen11_dsi_get_config(struct intel_encoder *encoder,
13131313
{
13141314
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
13151315
struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
1316-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1316+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
13171317

13181318
intel_dsc_get_config(encoder, pipe_config);
13191319

@@ -1417,7 +1417,8 @@ static void gen11_dsi_get_power_domains(struct intel_encoder *encoder,
14171417
{
14181418
struct drm_i915_private *i915 = to_i915(encoder->base.dev);
14191419

1420-
get_dsi_io_power_domains(i915, enc_to_intel_dsi(&encoder->base));
1420+
get_dsi_io_power_domains(i915,
1421+
enc_to_intel_dsi(encoder));
14211422

14221423
if (crtc_state->dsc.compression_enable)
14231424
intel_display_power_get(i915,
@@ -1428,7 +1429,7 @@ static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder,
14281429
enum pipe *pipe)
14291430
{
14301431
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1431-
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1432+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
14321433
enum transcoder dsi_trans;
14331434
intel_wakeref_t wakeref;
14341435
enum port port;

0 commit comments

Comments
 (0)