drm/xe/queue: fix engine_class bounds check

matt-auld · lucasdemarchi · commit b7dce525c4fc · 2024-03-25T13:45:32.000-05:00
The engine_class is the index into the user_to_xe_engine_class, therefore it needs to be less than. Fixes: dd08ebf ("drm/xe: Introduce a new DRM driver for Intel GPUs") Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240318180532.57522-4-matthew.auld@intel.com (cherry picked from commit fe87b7d) Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -448,7 +448,7 @@ find_hw_engine(struct xe_device *xe,
 {
 	u32 idx;
 
-	if (eci.engine_class > ARRAY_SIZE(user_to_xe_engine_class))
+	if (eci.engine_class >= ARRAY_SIZE(user_to_xe_engine_class))
 		return NULL;
 
 	if (eci.gt_id >= xe->info.gt_count)

Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,7 @@ find_hw_engine(struct xe_device *xe,`
`448`	`448`	`{`
`449`	`449`	`u32 idx;`
`450`	`450`
`451`		`- if (eci.engine_class > ARRAY_SIZE(user_to_xe_engine_class))`
	`451`	`+ if (eci.engine_class >= ARRAY_SIZE(user_to_xe_engine_class))`
`452`	`452`	`return NULL;`
`453`	`453`
`454`	`454`	`if (eci.gt_id >= xe->info.gt_count)`