Skip to content

Commit b7f317e

Browse files
committed
drm/i915/opregion: unify intel_encoder/intel_connector naming
Prefer the short encoder/connector names for struct intel_encoder/intel_connector variables and parameters. Reviewed-by: Imre Deak <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/60c67da6b7282ab521366524109ade0470408cf8.1723213547.git.jani.nikula@intel.com Signed-off-by: Jani Nikula <[email protected]>
1 parent f7303ab commit b7f317e

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

drivers/gpu/drm/i915/display/intel_opregion.c

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,10 @@ static int swsci(struct drm_i915_private *dev_priv,
381381
#define DISPLAY_TYPE_EXTERNAL_FLAT_PANEL 2
382382
#define DISPLAY_TYPE_INTERNAL_FLAT_PANEL 3
383383

384-
int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
384+
int intel_opregion_notify_encoder(struct intel_encoder *encoder,
385385
bool enable)
386386
{
387-
struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev);
387+
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
388388
u32 parm = 0;
389389
u32 type = 0;
390390
u32 port;
@@ -399,10 +399,10 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
399399
if (ret)
400400
return ret;
401401

402-
if (intel_encoder->type == INTEL_OUTPUT_DSI)
402+
if (encoder->type == INTEL_OUTPUT_DSI)
403403
port = 0;
404404
else
405-
port = intel_encoder->port;
405+
port = encoder->port;
406406

407407
if (port == PORT_E) {
408408
port = 0;
@@ -421,15 +421,15 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
421421
if (port > 4) {
422422
drm_dbg_kms(&dev_priv->drm,
423423
"[ENCODER:%d:%s] port %c (index %u) out of bounds for display power state notification\n",
424-
intel_encoder->base.base.id, intel_encoder->base.name,
425-
port_name(intel_encoder->port), port);
424+
encoder->base.base.id, encoder->base.name,
425+
port_name(encoder->port), port);
426426
return -EINVAL;
427427
}
428428

429429
if (!enable)
430430
parm |= 4 << 8;
431431

432-
switch (intel_encoder->type) {
432+
switch (encoder->type) {
433433
case INTEL_OUTPUT_ANALOG:
434434
type = DISPLAY_TYPE_CRT;
435435
break;
@@ -446,7 +446,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
446446
default:
447447
drm_WARN_ONCE(&dev_priv->drm, 1,
448448
"unsupported intel_encoder type %d\n",
449-
intel_encoder->type);
449+
encoder->type);
450450
return -EINVAL;
451451
}
452452

@@ -1093,7 +1093,7 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
10931093

10941094
/**
10951095
* intel_opregion_get_edid - Fetch EDID from ACPI OpRegion mailbox #5
1096-
* @intel_connector: eDP connector
1096+
* @connector: eDP connector
10971097
*
10981098
* This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed
10991099
* to it.
@@ -1102,10 +1102,9 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
11021102
* The EDID in the OpRegion, or NULL if there is none or it's invalid.
11031103
*
11041104
*/
1105-
const struct drm_edid *intel_opregion_get_edid(struct intel_connector *intel_connector)
1105+
const struct drm_edid *intel_opregion_get_edid(struct intel_connector *connector)
11061106
{
1107-
struct drm_connector *connector = &intel_connector->base;
1108-
struct drm_i915_private *i915 = to_i915(connector->dev);
1107+
struct drm_i915_private *i915 = to_i915(connector->base.dev);
11091108
struct intel_opregion *opregion = i915->display.opregion;
11101109
const struct drm_edid *drm_edid;
11111110
const void *edid;

drivers/gpu/drm/i915/display/intel_opregion.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ void intel_opregion_suspend(struct drm_i915_private *dev_priv,
4646

4747
bool intel_opregion_asle_present(struct drm_i915_private *i915);
4848
void intel_opregion_asle_intr(struct drm_i915_private *dev_priv);
49-
int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
49+
int intel_opregion_notify_encoder(struct intel_encoder *encoder,
5050
bool enable);
5151
int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv,
5252
pci_power_t state);
@@ -98,7 +98,7 @@ static inline void intel_opregion_asle_intr(struct drm_i915_private *dev_priv)
9898
}
9999

100100
static inline int
101-
intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, bool enable)
101+
intel_opregion_notify_encoder(struct intel_encoder *encoder, bool enable)
102102
{
103103
return 0;
104104
}

0 commit comments

Comments
 (0)