Skip to content

Commit b848f24

Browse files
committed
KVM: x86: Rename get_msr_feature() APIs to get_feature_msr()
Rename all APIs related to feature MSRs from get_msr_feature() to get_feature_msr(). The APIs get "feature MSRs", not "MSR features". And unlike kvm_{g,s}et_msr_common(), the "feature" adjective doesn't describe the helper itself. No functional change intended. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sean Christopherson <[email protected]>
1 parent 74c6c98 commit b848f24

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

arch/x86/include/asm/kvm-x86-ops.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ KVM_X86_OP_OPTIONAL(mem_enc_unregister_region)
125125
KVM_X86_OP_OPTIONAL(vm_copy_enc_context_from)
126126
KVM_X86_OP_OPTIONAL(vm_move_enc_context_from)
127127
KVM_X86_OP_OPTIONAL(guest_memory_reclaimed)
128-
KVM_X86_OP(get_msr_feature)
128+
KVM_X86_OP(get_feature_msr)
129129
KVM_X86_OP(check_emulate_instruction)
130130
KVM_X86_OP(apic_init_signal_blocked)
131131
KVM_X86_OP_OPTIONAL(enable_l2_tlb_flush)

arch/x86/include/asm/kvm_host.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1806,7 +1806,7 @@ struct kvm_x86_ops {
18061806
int (*vm_move_enc_context_from)(struct kvm *kvm, unsigned int source_fd);
18071807
void (*guest_memory_reclaimed)(struct kvm *kvm);
18081808

1809-
int (*get_msr_feature)(u32 msr, u64 *data);
1809+
int (*get_feature_msr)(u32 msr, u64 *data);
18101810

18111811
int (*check_emulate_instruction)(struct kvm_vcpu *vcpu, int emul_type,
18121812
void *insn, int insn_len);

arch/x86/kvm/svm/svm.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2825,7 +2825,7 @@ static int efer_trap(struct kvm_vcpu *vcpu)
28252825
return kvm_complete_insn_gp(vcpu, ret);
28262826
}
28272827

2828-
static int svm_get_msr_feature(u32 msr, u64 *data)
2828+
static int svm_get_feature_msr(u32 msr, u64 *data)
28292829
{
28302830
*data = 0;
28312831

@@ -3181,7 +3181,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr)
31813181
case MSR_AMD64_DE_CFG: {
31823182
u64 supported_de_cfg;
31833183

3184-
if (svm_get_msr_feature(ecx, &supported_de_cfg))
3184+
if (svm_get_feature_msr(ecx, &supported_de_cfg))
31853185
return 1;
31863186

31873187
if (data & ~supported_de_cfg)
@@ -5002,7 +5002,7 @@ static struct kvm_x86_ops svm_x86_ops __initdata = {
50025002
.vcpu_unblocking = avic_vcpu_unblocking,
50035003

50045004
.update_exception_bitmap = svm_update_exception_bitmap,
5005-
.get_msr_feature = svm_get_msr_feature,
5005+
.get_feature_msr = svm_get_feature_msr,
50065006
.get_msr = svm_get_msr,
50075007
.set_msr = svm_set_msr,
50085008
.get_segment_base = svm_get_segment_base,

arch/x86/kvm/vmx/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ struct kvm_x86_ops vt_x86_ops __initdata = {
4141
.vcpu_put = vmx_vcpu_put,
4242

4343
.update_exception_bitmap = vmx_update_exception_bitmap,
44-
.get_msr_feature = vmx_get_msr_feature,
44+
.get_feature_msr = vmx_get_feature_msr,
4545
.get_msr = vmx_get_msr,
4646
.set_msr = vmx_set_msr,
4747
.get_segment_base = vmx_get_segment_base,

arch/x86/kvm/vmx/vmx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1998,7 +1998,7 @@ static inline bool is_vmx_feature_control_msr_valid(struct vcpu_vmx *vmx,
19981998
return !(msr->data & ~valid_bits);
19991999
}
20002000

2001-
int vmx_get_msr_feature(u32 msr, u64 *data)
2001+
int vmx_get_feature_msr(u32 msr, u64 *data)
20022002
{
20032003
switch (msr) {
20042004
case KVM_FIRST_EMULATED_VMX_MSR ... KVM_LAST_EMULATED_VMX_MSR:

arch/x86/kvm/vmx/x86_ops.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ bool vmx_has_emulated_msr(struct kvm *kvm, u32 index);
5656
void vmx_msr_filter_changed(struct kvm_vcpu *vcpu);
5757
void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu);
5858
void vmx_update_exception_bitmap(struct kvm_vcpu *vcpu);
59-
int vmx_get_msr_feature(u32 msr, u64 *data);
59+
int vmx_get_feature_msr(u32 msr, u64 *data);
6060
int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info);
6161
u64 vmx_get_segment_base(struct kvm_vcpu *vcpu, int seg);
6262
void vmx_get_segment(struct kvm_vcpu *vcpu, struct kvm_segment *var, int seg);

arch/x86/kvm/x86.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1659,7 +1659,7 @@ static u64 kvm_get_arch_capabilities(void)
16591659
return data;
16601660
}
16611661

1662-
static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
1662+
static int kvm_get_feature_msr(struct kvm_msr_entry *msr)
16631663
{
16641664
switch (msr->index) {
16651665
case MSR_IA32_ARCH_CAPABILITIES:
@@ -1672,20 +1672,20 @@ static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
16721672
rdmsrl_safe(msr->index, &msr->data);
16731673
break;
16741674
default:
1675-
return kvm_x86_call(get_msr_feature)(msr->index, &msr->data);
1675+
return kvm_x86_call(get_feature_msr)(msr->index, &msr->data);
16761676
}
16771677
return 0;
16781678
}
16791679

1680-
static int do_get_msr_feature(struct kvm_vcpu *vcpu, unsigned index, u64 *data)
1680+
static int do_get_feature_msr(struct kvm_vcpu *vcpu, unsigned index, u64 *data)
16811681
{
16821682
struct kvm_msr_entry msr;
16831683
int r;
16841684

16851685
/* Unconditionally clear the output for simplicity */
16861686
msr.data = 0;
16871687
msr.index = index;
1688-
r = kvm_get_msr_feature(&msr);
1688+
r = kvm_get_feature_msr(&msr);
16891689

16901690
if (r == KVM_MSR_RET_UNSUPPORTED && kvm_msr_ignored_check(index, 0, false))
16911691
r = 0;
@@ -4943,7 +4943,7 @@ long kvm_arch_dev_ioctl(struct file *filp,
49434943
break;
49444944
}
49454945
case KVM_GET_MSRS:
4946-
r = msr_io(NULL, argp, do_get_msr_feature, 1);
4946+
r = msr_io(NULL, argp, do_get_feature_msr, 1);
49474947
break;
49484948
#ifdef CONFIG_KVM_HYPERV
49494949
case KVM_GET_SUPPORTED_HV_CPUID:
@@ -7382,7 +7382,7 @@ static void kvm_probe_feature_msr(u32 msr_index)
73827382
.index = msr_index,
73837383
};
73847384

7385-
if (kvm_get_msr_feature(&msr))
7385+
if (kvm_get_feature_msr(&msr))
73867386
return;
73877387

73887388
msr_based_features[num_msr_based_features++] = msr_index;

0 commit comments

Comments
 (0)