Skip to content

Commit b850b7a

Browse files
tiensunggregkh
authored andcommitted
firmware: stratix10-svc: add missing callback parameter on RSU
Fix a bug whereby, the return response of parameter a1 from an SMC call is not properly set to the callback data during an INTEL_SIP_SMC_RSU_ERROR command. Link: https://lore.kernel.org/lkml/[email protected] Fixes: 6b50d88 ("firmware: add remote status update client support") Cc: [email protected] Signed-off-by: Ang Tien Sung <[email protected]> Signed-off-by: Dinh Nguyen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8c8ce95 commit b850b7a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/firmware/stratix10-svc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ static int svc_normal_to_secure_thread(void *data)
483483
case INTEL_SIP_SMC_RSU_ERROR:
484484
pr_err("%s: STATUS_ERROR\n", __func__);
485485
cbdata->status = BIT(SVC_STATUS_ERROR);
486-
cbdata->kaddr1 = NULL;
486+
cbdata->kaddr1 = &res.a1;
487487
cbdata->kaddr2 = NULL;
488488
cbdata->kaddr3 = NULL;
489489
pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata);

0 commit comments

Comments
 (0)