Skip to content

Commit b8867ee

Browse files
tyhicksmimizohar
authored andcommitted
ima: Rename internal filter rule functions
Rename IMA's internal filter rule functions from security_filter_rule_*() to ima_filter_rule_*(). This avoids polluting the security_* namespace, which is typically reserved for general security subsystem infrastructure. Signed-off-by: Tyler Hicks <[email protected]> Suggested-by: Casey Schaufler <[email protected]> [[email protected]: reword using the term "filter", not "audit"] Signed-off-by: Mimi Zohar <[email protected]>
1 parent a068d93 commit b8867ee

File tree

2 files changed

+21
-25
lines changed

2 files changed

+21
-25
lines changed

security/integrity/ima/ima.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -413,24 +413,24 @@ static inline void ima_free_modsig(struct modsig *modsig)
413413
/* LSM based policy rules require audit */
414414
#ifdef CONFIG_IMA_LSM_RULES
415415

416-
#define security_filter_rule_init security_audit_rule_init
417-
#define security_filter_rule_free security_audit_rule_free
418-
#define security_filter_rule_match security_audit_rule_match
416+
#define ima_filter_rule_init security_audit_rule_init
417+
#define ima_filter_rule_free security_audit_rule_free
418+
#define ima_filter_rule_match security_audit_rule_match
419419

420420
#else
421421

422-
static inline int security_filter_rule_init(u32 field, u32 op, char *rulestr,
423-
void **lsmrule)
422+
static inline int ima_filter_rule_init(u32 field, u32 op, char *rulestr,
423+
void **lsmrule)
424424
{
425425
return -EINVAL;
426426
}
427427

428-
static inline void security_filter_rule_free(void *lsmrule)
428+
static inline void ima_filter_rule_free(void *lsmrule)
429429
{
430430
}
431431

432-
static inline int security_filter_rule_match(u32 secid, u32 field, u32 op,
433-
void *lsmrule)
432+
static inline int ima_filter_rule_match(u32 secid, u32 field, u32 op,
433+
void *lsmrule)
434434
{
435435
return -EINVAL;
436436
}

security/integrity/ima/ima_policy.c

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ static void ima_lsm_free_rule(struct ima_rule_entry *entry)
258258
int i;
259259

260260
for (i = 0; i < MAX_LSM_RULES; i++) {
261-
security_filter_rule_free(entry->lsm[i].rule);
261+
ima_filter_rule_free(entry->lsm[i].rule);
262262
kfree(entry->lsm[i].args_p);
263263
}
264264
}
@@ -308,10 +308,9 @@ static struct ima_rule_entry *ima_lsm_copy_rule(struct ima_rule_entry *entry)
308308
*/
309309
entry->lsm[i].args_p = NULL;
310310

311-
security_filter_rule_init(nentry->lsm[i].type,
312-
Audit_equal,
313-
nentry->lsm[i].args_p,
314-
&nentry->lsm[i].rule);
311+
ima_filter_rule_init(nentry->lsm[i].type, Audit_equal,
312+
nentry->lsm[i].args_p,
313+
&nentry->lsm[i].rule);
315314
if (!nentry->lsm[i].rule)
316315
pr_warn("rule for LSM \'%s\' is undefined\n",
317316
nentry->lsm[i].args_p);
@@ -495,18 +494,16 @@ static bool ima_match_rules(struct ima_rule_entry *rule, struct inode *inode,
495494
case LSM_OBJ_ROLE:
496495
case LSM_OBJ_TYPE:
497496
security_inode_getsecid(inode, &osid);
498-
rc = security_filter_rule_match(osid,
499-
rule->lsm[i].type,
500-
Audit_equal,
501-
rule->lsm[i].rule);
497+
rc = ima_filter_rule_match(osid, rule->lsm[i].type,
498+
Audit_equal,
499+
rule->lsm[i].rule);
502500
break;
503501
case LSM_SUBJ_USER:
504502
case LSM_SUBJ_ROLE:
505503
case LSM_SUBJ_TYPE:
506-
rc = security_filter_rule_match(secid,
507-
rule->lsm[i].type,
508-
Audit_equal,
509-
rule->lsm[i].rule);
504+
rc = ima_filter_rule_match(secid, rule->lsm[i].type,
505+
Audit_equal,
506+
rule->lsm[i].rule);
510507
default:
511508
break;
512509
}
@@ -901,10 +898,9 @@ static int ima_lsm_rule_init(struct ima_rule_entry *entry,
901898
return -ENOMEM;
902899

903900
entry->lsm[lsm_rule].type = audit_type;
904-
result = security_filter_rule_init(entry->lsm[lsm_rule].type,
905-
Audit_equal,
906-
entry->lsm[lsm_rule].args_p,
907-
&entry->lsm[lsm_rule].rule);
901+
result = ima_filter_rule_init(entry->lsm[lsm_rule].type, Audit_equal,
902+
entry->lsm[lsm_rule].args_p,
903+
&entry->lsm[lsm_rule].rule);
908904
if (!entry->lsm[lsm_rule].rule) {
909905
pr_warn("rule for LSM \'%s\' is undefined\n",
910906
entry->lsm[lsm_rule].args_p);

0 commit comments

Comments
 (0)