Skip to content

Commit b899434

Browse files
dhananjay-AMDsuperm1
authored andcommitted
cpufreq/amd-pstate: Remove the unnecessary cpufreq_update_policy call
The update_limits callback is only called in two conditions. * When the preferred core rankings change. In which case, we just need to change the prefcore ranking in the cpudata struct. As there are no changes to any of the perf values, there is no need to call cpufreq_update_policy() * When the _PPC ACPI object changes, i.e. the highest allowed Pstate changes. The _PPC object is only used for a table based cpufreq driver like acpi-cpufreq, hence is irrelevant for CPPC based amd-pstate. Hence, the cpufreq_update_policy() call becomes unnecessary and can be removed. Signed-off-by: Dhananjay Ugwekar <[email protected]> Reviewed-by: Mario Limonciello <[email protected]> Reviewed-by: Gautham R. Shenoy <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mario Limonciello <[email protected]>
1 parent 620136c commit b899434

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/cpufreq/amd-pstate.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -853,10 +853,6 @@ static void amd_pstate_update_limits(unsigned int cpu)
853853
sched_set_itmt_core_prio((int)cur_high, cpu);
854854
}
855855
cpufreq_cpu_put(policy);
856-
857-
if (!highest_perf_changed)
858-
cpufreq_update_policy(cpu);
859-
860856
}
861857

862858
/*

0 commit comments

Comments
 (0)