Skip to content

Commit b8b54ad

Browse files
committed
Merge tag 'icc-5.11-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc into char-misc-linus
Georgi writes: interconnect fixes for v5.11 This contains a few fixes for iMX and Qualcomm drivers and also updates my email to my kernel.org address. - qcom: Fix rpmh link failures when compile test is enabled - imx: Add a missing of_node_put after of_device_is_available - imx: Remove a useless test - imx8mq: Use icc_sync_state Signed-off-by: Georgi Djakov <[email protected]> * tag 'icc-5.11-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc: MAINTAINERS: Update Georgi's email address interconnect: imx8mq: Use icc_sync_state interconnect: imx: Remove a useless test interconnect: imx: Add a missing of_node_put after of_device_is_available interconnect: qcom: fix rpmh link failures
2 parents c9c48bb + 4b1a60a commit b8b54ad

File tree

4 files changed

+20
-10
lines changed

4 files changed

+20
-10
lines changed

MAINTAINERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9240,7 +9240,7 @@ F: tools/testing/selftests/sgx/*
92409240
K: \bSGX_
92419241

92429242
INTERCONNECT API
9243-
M: Georgi Djakov <georgi.djakov@linaro.org>
9243+
M: Georgi Djakov <djakov@kernel.org>
92449244
92459245
S: Maintained
92469246
F: Documentation/devicetree/bindings/interconnect/

drivers/interconnect/imx/imx.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,10 @@ static int imx_icc_node_init_qos(struct icc_provider *provider,
9696
return -ENODEV;
9797
}
9898
/* Allow scaling to be disabled on a per-node basis */
99-
if (!dn || !of_device_is_available(dn)) {
99+
if (!of_device_is_available(dn)) {
100100
dev_warn(dev, "Missing property %s, skip scaling %s\n",
101101
adj->phandle_name, node->name);
102+
of_node_put(dn);
102103
return 0;
103104
}
104105

drivers/interconnect/imx/imx8mq.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
#include <linux/module.h>
99
#include <linux/platform_device.h>
10+
#include <linux/interconnect-provider.h>
1011
#include <dt-bindings/interconnect/imx8mq.h>
1112

1213
#include "imx.h"
@@ -94,6 +95,7 @@ static struct platform_driver imx8mq_icc_driver = {
9495
.remove = imx8mq_icc_remove,
9596
.driver = {
9697
.name = "imx8mq-interconnect",
98+
.sync_state = icc_sync_state,
9799
},
98100
};
99101

drivers/interconnect/qcom/Kconfig

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,23 @@ config INTERCONNECT_QCOM_QCS404
4242
This is a driver for the Qualcomm Network-on-Chip on qcs404-based
4343
platforms.
4444

45+
config INTERCONNECT_QCOM_RPMH_POSSIBLE
46+
tristate
47+
default INTERCONNECT_QCOM
48+
depends on QCOM_RPMH || (COMPILE_TEST && !QCOM_RPMH)
49+
depends on QCOM_COMMAND_DB || (COMPILE_TEST && !QCOM_COMMAND_DB)
50+
depends on OF || COMPILE_TEST
51+
help
52+
Compile-testing RPMH drivers is possible on other platforms,
53+
but in order to avoid link failures, drivers must not be built-in
54+
when QCOM_RPMH or QCOM_COMMAND_DB are loadable modules
55+
4556
config INTERCONNECT_QCOM_RPMH
4657
tristate
4758

4859
config INTERCONNECT_QCOM_SC7180
4960
tristate "Qualcomm SC7180 interconnect driver"
50-
depends on INTERCONNECT_QCOM
51-
depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
61+
depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
5262
select INTERCONNECT_QCOM_RPMH
5363
select INTERCONNECT_QCOM_BCM_VOTER
5464
help
@@ -57,8 +67,7 @@ config INTERCONNECT_QCOM_SC7180
5767

5868
config INTERCONNECT_QCOM_SDM845
5969
tristate "Qualcomm SDM845 interconnect driver"
60-
depends on INTERCONNECT_QCOM
61-
depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
70+
depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
6271
select INTERCONNECT_QCOM_RPMH
6372
select INTERCONNECT_QCOM_BCM_VOTER
6473
help
@@ -67,8 +76,7 @@ config INTERCONNECT_QCOM_SDM845
6776

6877
config INTERCONNECT_QCOM_SM8150
6978
tristate "Qualcomm SM8150 interconnect driver"
70-
depends on INTERCONNECT_QCOM
71-
depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
79+
depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
7280
select INTERCONNECT_QCOM_RPMH
7381
select INTERCONNECT_QCOM_BCM_VOTER
7482
help
@@ -77,8 +85,7 @@ config INTERCONNECT_QCOM_SM8150
7785

7886
config INTERCONNECT_QCOM_SM8250
7987
tristate "Qualcomm SM8250 interconnect driver"
80-
depends on INTERCONNECT_QCOM
81-
depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
88+
depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
8289
select INTERCONNECT_QCOM_RPMH
8390
select INTERCONNECT_QCOM_BCM_VOTER
8491
help

0 commit comments

Comments
 (0)