Skip to content

Commit b91e840

Browse files
author
Paolo Abeni
committed
Merge branch 'rswitch-fix-issues-on-specific-conditions'
Yoshihiro Shimoda says: ==================== rswitch: Fix issues on specific conditions This patch series fix some issues of rswitch driver on specific condtions. ==================== Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
2 parents 50e4921 + 053f13f commit b91e840

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

drivers/net/ethernet/renesas/rswitch.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,7 +1254,7 @@ static void rswitch_adjust_link(struct net_device *ndev)
12541254
phy_print_status(phydev);
12551255
if (phydev->link)
12561256
phy_power_on(rdev->serdes);
1257-
else
1257+
else if (rdev->serdes->power_count)
12581258
phy_power_off(rdev->serdes);
12591259

12601260
rdev->etha->link = phydev->link;
@@ -1964,15 +1964,17 @@ static void rswitch_deinit(struct rswitch_private *priv)
19641964
rswitch_gwca_hw_deinit(priv);
19651965
rcar_gen4_ptp_unregister(priv->ptp_priv);
19661966

1967-
for (i = 0; i < RSWITCH_NUM_PORTS; i++) {
1967+
rswitch_for_each_enabled_port(priv, i) {
19681968
struct rswitch_device *rdev = priv->rdev[i];
19691969

1970-
phy_exit(priv->rdev[i]->serdes);
1971-
rswitch_ether_port_deinit_one(rdev);
19721970
unregister_netdev(rdev->ndev);
1973-
rswitch_device_free(priv, i);
1971+
rswitch_ether_port_deinit_one(rdev);
1972+
phy_exit(priv->rdev[i]->serdes);
19741973
}
19751974

1975+
for (i = 0; i < RSWITCH_NUM_PORTS; i++)
1976+
rswitch_device_free(priv, i);
1977+
19761978
rswitch_gwca_ts_queue_free(priv);
19771979
rswitch_gwca_linkfix_free(priv);
19781980

0 commit comments

Comments
 (0)