Skip to content

Commit b9b1a5d

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: remove blk_queue_stack_limits
This function is just a tiny wrapper around blk_stack_limits. Open code it int the two callers. Reviewed-by: Johannes Thumshirn <[email protected]> Reviewed-by: Damien Le Moal <[email protected]> Tested-by: Damien Le Moal <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 9efa82e commit b9b1a5d

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

block/blk-settings.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -455,17 +455,6 @@ void blk_queue_io_opt(struct request_queue *q, unsigned int opt)
455455
}
456456
EXPORT_SYMBOL(blk_queue_io_opt);
457457

458-
/**
459-
* blk_queue_stack_limits - inherit underlying queue limits for stacked drivers
460-
* @t: the stacking driver (top)
461-
* @b: the underlying device (bottom)
462-
**/
463-
void blk_queue_stack_limits(struct request_queue *t, struct request_queue *b)
464-
{
465-
blk_stack_limits(&t->limits, &b->limits, 0);
466-
}
467-
EXPORT_SYMBOL(blk_queue_stack_limits);
468-
469458
/**
470459
* blk_stack_limits - adjust queue_limits for stacked devices
471460
* @t: the stacking driver limits (top device)

drivers/block/drbd/drbd_nl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1250,7 +1250,7 @@ static void fixup_discard_if_not_supported(struct request_queue *q)
12501250

12511251
static void fixup_write_zeroes(struct drbd_device *device, struct request_queue *q)
12521252
{
1253-
/* Fixup max_write_zeroes_sectors after blk_queue_stack_limits():
1253+
/* Fixup max_write_zeroes_sectors after blk_stack_limits():
12541254
* if we can handle "zeroes" efficiently on the protocol,
12551255
* we want to do that, even if our backend does not announce
12561256
* max_write_zeroes_sectors itself. */
@@ -1361,7 +1361,7 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
13611361
decide_on_write_same_support(device, q, b, o, disable_write_same);
13621362

13631363
if (b) {
1364-
blk_queue_stack_limits(q, b);
1364+
blk_stack_limits(&q->limits, &b->limits, 0);
13651365

13661366
if (q->backing_dev_info->ra_pages !=
13671367
b->backing_dev_info->ra_pages) {

drivers/nvme/host/core.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2054,7 +2054,8 @@ static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id)
20542054
#ifdef CONFIG_NVME_MULTIPATH
20552055
if (ns->head->disk) {
20562056
nvme_update_disk_info(ns->head->disk, ns, id);
2057-
blk_queue_stack_limits(ns->head->disk->queue, ns->queue);
2057+
blk_stack_limits(&ns->head->disk->queue->limits,
2058+
&ns->queue->limits, 0);
20582059
nvme_mpath_update_disk_size(ns->head->disk);
20592060
}
20602061
#endif

include/linux/blkdev.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1141,7 +1141,6 @@ extern int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
11411141
sector_t offset);
11421142
extern void disk_stack_limits(struct gendisk *disk, struct block_device *bdev,
11431143
sector_t offset);
1144-
extern void blk_queue_stack_limits(struct request_queue *t, struct request_queue *b);
11451144
extern void blk_queue_update_dma_pad(struct request_queue *, unsigned int);
11461145
extern void blk_queue_segment_boundary(struct request_queue *, unsigned long);
11471146
extern void blk_queue_virt_boundary(struct request_queue *, unsigned long);

0 commit comments

Comments
 (0)