Skip to content

Commit b9c7ac4

Browse files
hkallweitkuba-moo
authored andcommitted
r8169: disable ALDPS per default for RTL8125
En-Wei reported that traffic breaks if cable is unplugged for more than 3s and then re-plugged. This was supposed to be fixed by 621735f ("r8169: fix rare issue with broken rx after link-down on RTL8125"). But apparently this didn't fix the issue for everybody. The 3s threshold rang a bell, as this is the delay after which ALDPS kicks in. And indeed disabling ALDPS fixes the issue for this user. Maybe this fixes the issue in general. In a follow-up step we could remove the first fix attempt and see whether anybody complains. Fixes: f1bce4a ("r8169: add support for RTL8125") Tested-by: En-Wei WU <[email protected]> Signed-off-by: Heiner Kallweit <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 157f291 commit b9c7ac4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/ethernet/realtek/r8169_phy_config.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,6 +1060,7 @@ static void rtl8125a_2_hw_phy_config(struct rtl8169_private *tp,
10601060
phy_modify_paged(phydev, 0xa86, 0x15, 0x0001, 0x0000);
10611061
rtl8168g_enable_gphy_10m(phydev);
10621062

1063+
rtl8168g_disable_aldps(phydev);
10631064
rtl8125a_config_eee_phy(phydev);
10641065
}
10651066

@@ -1099,6 +1100,7 @@ static void rtl8125b_hw_phy_config(struct rtl8169_private *tp,
10991100
phy_modify_paged(phydev, 0xbf8, 0x12, 0xe000, 0xa000);
11001101

11011102
rtl8125_legacy_force_mode(phydev);
1103+
rtl8168g_disable_aldps(phydev);
11021104
rtl8125b_config_eee_phy(phydev);
11031105
}
11041106

0 commit comments

Comments
 (0)