Skip to content

Commit ba27e9d

Browse files
dmaengine: ti: k3-udma-glue: Fix of_k3_udma_glue_parse_chn_by_id()
The of_k3_udma_glue_parse_chn_by_id() helper function erroneously invokes "of_node_put()" on the "udmax_np" device-node passed to it, without having incremented its reference count at any point. Fix it. Fixes: 81a1f90 ("dmaengine: ti: k3-udma-glue: Add function to parse channel by ID") Signed-off-by: Siddharth Vadapalli <[email protected]> Acked-by: Peter Ujfalusi <[email protected]> Acked-by: Peter [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent e3215de commit ba27e9d

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

drivers/dma/ti/k3-udma-glue.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,9 @@ of_k3_udma_glue_parse_chn_by_id(struct device_node *udmax_np, struct k3_udma_glu
200200

201201
ret = of_k3_udma_glue_parse(udmax_np, common);
202202
if (ret)
203-
goto out_put_spec;
203+
return ret;
204204

205205
ret = of_k3_udma_glue_parse_chn_common(common, thread_id, tx_chn);
206-
207-
out_put_spec:
208-
of_node_put(udmax_np);
209206
return ret;
210207
}
211208

0 commit comments

Comments
 (0)