Skip to content

Commit ba3a80f

Browse files
Peter Chenfelipebalbi
authored andcommitted
usb: cdns3: trace: using correct dir value
It should use the correct direction value from register, not depends on previous software setting. It fixed the EP number wrong issue at trace when the TRBERR interrupt occurs for EP0IN. When the EP0IN IOC has finished, software prepares the setup packet request, the expected direction is OUT, but at that time, the TRBERR for EP0IN may occur since it is DMULT mode, the DMA does not stop until TRBERR has met. Cc: <[email protected]> Fixes: 7733f6c ("usb: cdns3: Add Cadence USB3 DRD Driver") Reviewed-by: Pawel Laszczak <[email protected]> Signed-off-by: Peter Chen <[email protected]> Signed-off-by: Felipe Balbi <[email protected]>
1 parent b51e1cf commit ba3a80f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/usb/cdns3/trace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ DECLARE_EVENT_CLASS(cdns3_log_ep0_irq,
156156
__dynamic_array(char, str, CDNS3_MSG_MAX)
157157
),
158158
TP_fast_assign(
159-
__entry->ep_dir = priv_dev->ep0_data_dir;
159+
__entry->ep_dir = priv_dev->selected_ep;
160160
__entry->ep_sts = ep_sts;
161161
),
162162
TP_printk("%s", cdns3_decode_ep0_irq(__get_str(str),

0 commit comments

Comments
 (0)