Skip to content

Commit ba3f929

Browse files
jwrdegoedeJiri Kosina
authored andcommitted
HID: elan: Remove elan_mute_led_get_brigtness()
The led_classdev already contains a cached value of the last set brightness, the brightness_get callback is only meant for LED drivers which can read back the actual / current brightness from the hardware. Since elan_mute_led_get_brigtness() just returns the last set value it does not add any functionality, so we can just remove it. Reviewed-by: Marek Behún <[email protected]> Acked-by: Pavel Machek <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 2601371 commit ba3f929

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

drivers/hid/hid-elan.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -410,15 +410,6 @@ static int elan_start_multitouch(struct hid_device *hdev)
410410
return 0;
411411
}
412412

413-
static enum led_brightness elan_mute_led_get_brigtness(struct led_classdev *led_cdev)
414-
{
415-
struct device *dev = led_cdev->dev->parent;
416-
struct hid_device *hdev = to_hid_device(dev);
417-
struct elan_drvdata *drvdata = hid_get_drvdata(hdev);
418-
419-
return drvdata->mute_led_state;
420-
}
421-
422413
static int elan_mute_led_set_brigtness(struct led_classdev *led_cdev,
423414
enum led_brightness value)
424415
{
@@ -461,7 +452,6 @@ static int elan_init_mute_led(struct hid_device *hdev)
461452

462453
mute_led->name = "elan:red:mute";
463454
mute_led->default_trigger = "audio-mute";
464-
mute_led->brightness_get = elan_mute_led_get_brigtness;
465455
mute_led->brightness_set_blocking = elan_mute_led_set_brigtness;
466456
mute_led->max_brightness = LED_ON;
467457
mute_led->flags = LED_HW_PLUGGABLE;

0 commit comments

Comments
 (0)