Skip to content

Commit ba60cf9

Browse files
WillLesterdtor
authored andcommitted
Input: synaptics-rmi4 - destroy F54 poller workqueue when removing
The driver forgets to destroy workqueue in remove() similarly to what is done when probe() fails. Add a call to destroy_workqueue() to fix it. Since unregistration will wait for the work to finish, we do not need to cancel/flush the work instance in remove(). Signed-off-by: Chuhong Yuan <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent fa3a5a1 commit ba60cf9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/input/rmi4/rmi_f54.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -730,6 +730,7 @@ static void rmi_f54_remove(struct rmi_function *fn)
730730

731731
video_unregister_device(&f54->vdev);
732732
v4l2_device_unregister(&f54->v4l2);
733+
destroy_workqueue(f54->workqueue);
733734
}
734735

735736
struct rmi_function_handler rmi_f54_handler = {

0 commit comments

Comments
 (0)