Skip to content

Commit ba7b663

Browse files
Shyam Sundar S Kij-intel
authored andcommitted
platform/x86/amd/pmc: Fix SMU command submission path on new AMD platform
The commit 426463d ("platform/x86/amd/pmc: Send OS_HINT command for new AMD platform") was introduced to enable sending mailbox commands to PMFW on newer platforms. However, it was later discovered that the commit did not configure the correct message port ID (i.e., S2D or PMC). Without this configuration, all command submissions to PMFW are treated as invalid, leading to command failures. To address this issue, the CPU ID association for the new platform needs to be added in amd_pmc_get_ip_info(). This ensures that the correct SMU port IDs are selected. Fixes: 426463d ("platform/x86/amd/pmc: Send OS_HINT command for new AMD platform") Co-developed-by: Sanket Goswami <[email protected]> Signed-off-by: Sanket Goswami <[email protected]> Signed-off-by: Shyam Sundar S K <[email protected]> Reviewed-by: Mario Limonciello <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Ilpo Järvinen <[email protected]> Signed-off-by: Ilpo Järvinen <[email protected]>
1 parent 46ee21e commit ba7b663

File tree

1 file changed

+1
-0
lines changed
  • drivers/platform/x86/amd/pmc

1 file changed

+1
-0
lines changed

drivers/platform/x86/amd/pmc/pmc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ static void amd_pmc_get_ip_info(struct amd_pmc_dev *dev)
359359
dev->smu_msg = 0x538;
360360
break;
361361
case PCI_DEVICE_ID_AMD_1AH_M20H_ROOT:
362+
case PCI_DEVICE_ID_AMD_1AH_M60H_ROOT:
362363
dev->num_ips = 22;
363364
dev->s2d_msg_id = 0xDE;
364365
dev->smu_msg = 0x938;

0 commit comments

Comments
 (0)