ovl: fix tmpfile leak

Miklos Szeredi · Miklos Szeredi · commit baabaa505563 · 2023-01-27T16:16:12.000+01:00
Missed an error cleanup. Reported-by: syzbot+fd749a7ea127a84e0ffd@syzkaller.appspotmail.com Fixes: 2b1a774 ("ovl: use vfs_tmpfile_open() helper") Cc: <stable@vger.kernel.org> # v6.1 Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
@@ -792,7 +792,7 @@ static int ovl_copy_up_tmpfile(struct ovl_copy_up_ctx *c)
 	if (!c->metacopy && c->stat.size) {
 		err = ovl_copy_up_file(ofs, c->dentry, tmpfile, c->stat.size);
 		if (err)
-			return err;
+			goto out_fput;
 	}
 
 	err = ovl_copy_up_metadata(c, temp);

Original file line number	Diff line number	Diff line change
`@@ -792,7 +792,7 @@ static int ovl_copy_up_tmpfile(struct ovl_copy_up_ctx *c)`
`792`	`792`	`if (!c->metacopy && c->stat.size) {`
`793`	`793`	`err = ovl_copy_up_file(ofs, c->dentry, tmpfile, c->stat.size);`
`794`	`794`	`if (err)`
`795`		`- return err;`
	`795`	`+ goto out_fput;`
`796`	`796`	`}`
`797`	`797`
`798`	`798`	`err = ovl_copy_up_metadata(c, temp);`