Skip to content

Commit bab5503

Browse files
drvgithubuserJuliaLawall
authored andcommitted
coccinelle: api/atomic_as_refcounter: include message type in output
A common practice is to grep for "WARNING" or "ERROR" text in the report output from a Coccinelle semantic patch script. So, include the text "WARNING: " in the report output generated by the semantic patch for desired filtering of the output. Also improves the readability of the output. Here is an example of the old and new outputs reported: xyz_file.c:131:39-40: atomic_add_unless xyz_file.c:131:39-40: WARNING: atomic_add_unless xyz_file.c:196:6-25: atomic_dec_and_test variation before object free at line 208. xyz_file.c:196:6-25: WARNING: atomic_dec_and_test variation before object free at line 208. Signed-off-by: Deepak R Varma <[email protected]> Acked-by: Julia Lawall <[email protected]>
1 parent 1b929c0 commit bab5503

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

scripts/coccinelle/api/atomic_as_refcounter.cocci

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ identifier fname6 =~ ".*call_rcu.*";
5555
p1 << r1.p1;
5656
p2 << r1.p2;
5757
@@
58-
msg = "atomic_dec_and_test variation before object free at line %s."
58+
msg = "WARNING: atomic_dec_and_test variation before object free at line %s."
5959
coccilib.report.print_report(p1[0], msg % (p2[0].line))
6060
6161
@r4 exists@
@@ -88,7 +88,7 @@ fname@p2(y, ...);
8888
p1 << r4.p1;
8989
p2 << r4.p2;
9090
@@
91-
msg = "atomic_dec_and_test variation before object free at line %s."
91+
msg = "WARNING: atomic_dec_and_test variation before object free at line %s."
9292
coccilib.report.print_report(p1[0], msg % (p2[0].line))
9393
9494
@r2 exists@
@@ -107,7 +107,7 @@ atomic64_add_unless(&(a)->x,-1,1)@p1
107107
@script:python depends on report@
108108
p1 << r2.p1;
109109
@@
110-
msg = "atomic_add_unless"
110+
msg = "WARNING: atomic_add_unless"
111111
coccilib.report.print_report(p1[0], msg)
112112
113113
@r3 exists@
@@ -126,5 +126,5 @@ x = atomic64_add_return@p1(-1, ...);
126126
@script:python depends on report@
127127
p1 << r3.p1;
128128
@@
129-
msg = "x = atomic_add_return(-1, ...)"
129+
msg = "WARNING: x = atomic_add_return(-1, ...)"
130130
coccilib.report.print_report(p1[0], msg)

0 commit comments

Comments
 (0)