Skip to content

Commit bae361c

Browse files
Michael Chandavem330
authored andcommitted
bnxt_en: Improve AER slot reset.
Improve the slot reset sequence by disabling the device to prevent bad DMAs if slot reset fails. Return the proper result instead of always PCI_ERS_RESULT_RECOVERED to the caller. Fixes: 6316ea6 ("bnxt_en: Enable AER support.") Signed-off-by: Michael Chan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9e68cb0 commit bae361c

File tree

1 file changed

+6
-3
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+6
-3
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12212,12 +12212,15 @@ static pci_ers_result_t bnxt_io_slot_reset(struct pci_dev *pdev)
1221212212
bnxt_ulp_start(bp, err);
1221312213
}
1221412214

12215-
if (result != PCI_ERS_RESULT_RECOVERED && netif_running(netdev))
12216-
dev_close(netdev);
12215+
if (result != PCI_ERS_RESULT_RECOVERED) {
12216+
if (netif_running(netdev))
12217+
dev_close(netdev);
12218+
pci_disable_device(pdev);
12219+
}
1221712220

1221812221
rtnl_unlock();
1221912222

12220-
return PCI_ERS_RESULT_RECOVERED;
12223+
return result;
1222112224
}
1222212225

1222312226
/**

0 commit comments

Comments
 (0)