Skip to content

Commit bb17b2c

Browse files
jwrdegoedeBenjamin Tissoires
authored andcommitted
HID: logitech-hidpp: Remove unused connected param from *_connect()
Remove the unused connected function parameter from wtp_connect(), m560_send_config_command() and k400_connect(). This is a preparation patch for moving all connected state handling to hidpp_connect_event(). This series has been tested on the following devices: Logitech Bluetooth Laser Travel Mouse (bluetooth, HID++ 1.0) Logitech M720 Triathlon (bluetooth, HID++ 4.5) Logitech M720 Triathlon (unifying, HID++ 4.5) Logitech K400 Pro (unifying, HID++ 4.1) Logitech K270 (eQUAD nano Lite, HID++ 2.0) Logitech M185 (eQUAD nano Lite, HID++ 4.5) Logitech LX501 keyboard (27 Mhz, HID++ builtin scroll-wheel, HID++ 1.0) Logitech M-RAZ105 mouse (27 Mhz, HID++ extra mouse buttons, HID++ 1.0) And by bentiss: Logitech Touchpad T650 (unifying) Logitech Touchpad T651 (bluetooth) Logitech MX Master 3B (BLE) Logitech G403 (plain USB / Gaming receiver) Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Benjamin Tissoires <[email protected]>
1 parent 6f335b4 commit bb17b2c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/hid/hid-logitech-hidpp.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3141,7 +3141,7 @@ static int wtp_allocate(struct hid_device *hdev, const struct hid_device_id *id)
31413141
return 0;
31423142
};
31433143

3144-
static int wtp_connect(struct hid_device *hdev, bool connected)
3144+
static int wtp_connect(struct hid_device *hdev)
31453145
{
31463146
struct hidpp_device *hidpp = hid_get_drvdata(hdev);
31473147
struct wtp_data *wd = hidpp->private_data;
@@ -3203,7 +3203,7 @@ static const u8 m560_config_parameter[] = {0x00, 0xaf, 0x03};
32033203
#define M560_SUB_ID 0x0a
32043204
#define M560_BUTTON_MODE_REGISTER 0x35
32053205

3206-
static int m560_send_config_command(struct hid_device *hdev, bool connected)
3206+
static int m560_send_config_command(struct hid_device *hdev)
32073207
{
32083208
struct hidpp_report response;
32093209
struct hidpp_device *hidpp_dev;
@@ -3398,7 +3398,7 @@ static int k400_allocate(struct hid_device *hdev)
33983398
return 0;
33993399
};
34003400

3401-
static int k400_connect(struct hid_device *hdev, bool connected)
3401+
static int k400_connect(struct hid_device *hdev)
34023402
{
34033403
struct hidpp_device *hidpp = hid_get_drvdata(hdev);
34043404

@@ -4205,15 +4205,15 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)
42054205
}
42064206

42074207
if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {
4208-
ret = wtp_connect(hdev, connected);
4208+
ret = wtp_connect(hdev);
42094209
if (ret)
42104210
return;
42114211
} else if (hidpp->quirks & HIDPP_QUIRK_CLASS_M560) {
4212-
ret = m560_send_config_command(hdev, connected);
4212+
ret = m560_send_config_command(hdev);
42134213
if (ret)
42144214
return;
42154215
} else if (hidpp->quirks & HIDPP_QUIRK_CLASS_K400) {
4216-
ret = k400_connect(hdev, connected);
4216+
ret = k400_connect(hdev);
42174217
if (ret)
42184218
return;
42194219
}

0 commit comments

Comments
 (0)