Skip to content

Commit bb18265

Browse files
hkallweitkuba-moo
authored andcommitted
r8169: remove support for chip version 11
This is a follow-up to 982300c ("r8169: remove detection of chip version 11 (early RTL8168b)"). Nobody complained yet, so remove support for this chip version. Signed-off-by: Heiner Kallweit <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 2e20bf8 commit bb18265

File tree

3 files changed

+2
-24
lines changed

3 files changed

+2
-24
lines changed

drivers/net/ethernet/realtek/r8169.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ enum mac_version {
2323
RTL_GIGA_MAC_VER_08,
2424
RTL_GIGA_MAC_VER_09,
2525
RTL_GIGA_MAC_VER_10,
26-
RTL_GIGA_MAC_VER_11,
26+
/* support for RTL_GIGA_MAC_VER_11 has been removed */
2727
/* RTL_GIGA_MAC_VER_12 was handled the same as VER_17 */
2828
/* RTL_GIGA_MAC_VER_13 was merged with VER_10 */
2929
RTL_GIGA_MAC_VER_14,

drivers/net/ethernet/realtek/r8169_main.c

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ static const struct {
104104
[RTL_GIGA_MAC_VER_08] = {"RTL8102e" },
105105
[RTL_GIGA_MAC_VER_09] = {"RTL8102e/RTL8103e" },
106106
[RTL_GIGA_MAC_VER_10] = {"RTL8101e/RTL8100e" },
107-
[RTL_GIGA_MAC_VER_11] = {"RTL8168b/8111b" },
108107
[RTL_GIGA_MAC_VER_14] = {"RTL8401" },
109108
[RTL_GIGA_MAC_VER_17] = {"RTL8168b/8111b" },
110109
[RTL_GIGA_MAC_VER_18] = {"RTL8168cp/8111cp" },
@@ -2335,7 +2334,7 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
23352334

23362335
/* 8168B family. */
23372336
{ 0x7c8, 0x380, RTL_GIGA_MAC_VER_17 },
2338-
/* This one is very old and rare, let's see if anybody complains.
2337+
/* This one is very old and rare, support has been removed.
23392338
* { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 },
23402339
*/
23412340

@@ -3803,7 +3802,6 @@ static void rtl_hw_config(struct rtl8169_private *tp)
38033802
[RTL_GIGA_MAC_VER_08] = rtl_hw_start_8102e_3,
38043803
[RTL_GIGA_MAC_VER_09] = rtl_hw_start_8102e_2,
38053804
[RTL_GIGA_MAC_VER_10] = NULL,
3806-
[RTL_GIGA_MAC_VER_11] = rtl_hw_start_8168b,
38073805
[RTL_GIGA_MAC_VER_14] = rtl_hw_start_8401,
38083806
[RTL_GIGA_MAC_VER_17] = rtl_hw_start_8168b,
38093807
[RTL_GIGA_MAC_VER_18] = rtl_hw_start_8168cp_1,
@@ -4679,12 +4677,6 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance)
46794677
if (status & LinkChg)
46804678
phy_mac_interrupt(tp->phydev);
46814679

4682-
if (unlikely(status & RxFIFOOver &&
4683-
tp->mac_version == RTL_GIGA_MAC_VER_11)) {
4684-
netif_stop_queue(tp->dev);
4685-
rtl_schedule_task(tp, RTL_FLAG_TASK_RESET_PENDING);
4686-
}
4687-
46884680
rtl_irq_disable(tp);
46894681
napi_schedule(&tp->napi);
46904682
out:
@@ -5100,9 +5092,6 @@ static void rtl_set_irq_mask(struct rtl8169_private *tp)
51005092

51015093
if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
51025094
tp->irq_mask |= SYSErr | RxFIFOOver;
5103-
else if (tp->mac_version == RTL_GIGA_MAC_VER_11)
5104-
/* special workaround needed */
5105-
tp->irq_mask |= RxFIFOOver;
51065095
}
51075096

51085097
static int rtl_alloc_irq(struct rtl8169_private *tp)
@@ -5297,7 +5286,6 @@ static int rtl_jumbo_max(struct rtl8169_private *tp)
52975286
case RTL_GIGA_MAC_VER_02 ... RTL_GIGA_MAC_VER_06:
52985287
return JUMBO_7K;
52995288
/* RTL8168b */
5300-
case RTL_GIGA_MAC_VER_11:
53015289
case RTL_GIGA_MAC_VER_17:
53025290
return JUMBO_4K;
53035291
/* RTL8168c */

drivers/net/ethernet/realtek/r8169_phy_config.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -276,15 +276,6 @@ static void rtl8169sce_hw_phy_config(struct rtl8169_private *tp,
276276
rtl_writephy_batch(phydev, phy_reg_init);
277277
}
278278

279-
static void rtl8168bb_hw_phy_config(struct rtl8169_private *tp,
280-
struct phy_device *phydev)
281-
{
282-
phy_write(phydev, 0x1f, 0x0001);
283-
phy_set_bits(phydev, 0x16, BIT(0));
284-
phy_write(phydev, 0x10, 0xf41b);
285-
phy_write(phydev, 0x1f, 0x0000);
286-
}
287-
288279
static void rtl8168bef_hw_phy_config(struct rtl8169_private *tp,
289280
struct phy_device *phydev)
290281
{
@@ -1136,7 +1127,6 @@ void r8169_hw_phy_config(struct rtl8169_private *tp, struct phy_device *phydev,
11361127
[RTL_GIGA_MAC_VER_08] = rtl8102e_hw_phy_config,
11371128
[RTL_GIGA_MAC_VER_09] = rtl8102e_hw_phy_config,
11381129
[RTL_GIGA_MAC_VER_10] = NULL,
1139-
[RTL_GIGA_MAC_VER_11] = rtl8168bb_hw_phy_config,
11401130
[RTL_GIGA_MAC_VER_14] = rtl8401_hw_phy_config,
11411131
[RTL_GIGA_MAC_VER_17] = rtl8168bef_hw_phy_config,
11421132
[RTL_GIGA_MAC_VER_18] = rtl8168cp_1_hw_phy_config,

0 commit comments

Comments
 (0)