Skip to content

Commit bb24174

Browse files
old-memoriesaxboe
authored andcommitted
ublk_drv: update comment for __ublk_fail_req()
Since __ublk_rq_task_work always fails requests immediately during exiting, __ublk_fail_req() is only called from abort context during exiting. So lock is unnecessary. Signed-off-by: ZiyangZhang <[email protected]> Reviewed-by: Ming Lei <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 966120b commit bb24174

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/block/ublk_drv.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,8 +605,9 @@ static void ublk_complete_rq(struct request *req)
605605
}
606606

607607
/*
608-
* __ublk_fail_req() may be called from abort context or ->ubq_daemon
609-
* context during exiting, so lock is required.
608+
* Since __ublk_rq_task_work always fails requests immediately during
609+
* exiting, __ublk_fail_req() is only called from abort context during
610+
* exiting. So lock is unnecessary.
610611
*
611612
* Also aborting may not be started yet, keep in mind that one failed
612613
* request may be issued by block layer again.

0 commit comments

Comments
 (0)