Skip to content

Commit bb91408

Browse files
cpackham-atlnzWim Van Sebroeck
authored andcommitted
watchdog: orion: use 0 for unset heartbeat
If the heartbeat module param is not specified we would get an error message watchdog: f1020300.watchdog: driver supplied timeout (4294967295) out of range watchdog: f1020300.watchdog: falling back to default timeout (171) This is because we were initialising heartbeat to -1. By removing the initialisation (thus letting the C run time initialise it to 0) we silence the warning message and the default timeout is still used. Signed-off-by: Chris Packham <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent f667421 commit bb91408

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/watchdog/orion_wdt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
#define WDT_A370_RATIO (1 << WDT_A370_RATIO_SHIFT)
5353

5454
static bool nowayout = WATCHDOG_NOWAYOUT;
55-
static int heartbeat = -1; /* module parameter (seconds) */
55+
static int heartbeat; /* module parameter (seconds) */
5656

5757
struct orion_watchdog;
5858

0 commit comments

Comments
 (0)