Skip to content

Commit bbd5593

Browse files
ebiggerstytso
authored andcommitted
ext4: rename s_journal_flag_rwsem to s_writepages_rwsem
In preparation for making s_journal_flag_rwsem synchronize ext4_writepages() with changes to both the EXTENTS and JOURNAL_DATA flags (rather than just JOURNAL_DATA as it does currently), rename it to s_writepages_rwsem. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Eric Biggers <[email protected]> Signed-off-by: Theodore Ts'o <[email protected]> Reviewed-by: Jan Kara <[email protected]> Cc: [email protected]
1 parent 7c99072 commit bbd5593

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

fs/ext4/ext4.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1553,7 +1553,7 @@ struct ext4_sb_info {
15531553
struct ratelimit_state s_msg_ratelimit_state;
15541554

15551555
/* Barrier between changing inodes' journal flags and writepages ops. */
1556-
struct percpu_rw_semaphore s_journal_flag_rwsem;
1556+
struct percpu_rw_semaphore s_writepages_rwsem;
15571557
struct dax_device *s_daxdev;
15581558
#ifdef CONFIG_EXT4_DEBUG
15591559
unsigned long s_simulate_fail;

fs/ext4/inode.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2628,7 +2628,7 @@ static int ext4_writepages(struct address_space *mapping,
26282628
if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
26292629
return -EIO;
26302630

2631-
percpu_down_read(&sbi->s_journal_flag_rwsem);
2631+
percpu_down_read(&sbi->s_writepages_rwsem);
26322632
trace_ext4_writepages(inode, wbc);
26332633

26342634
/*
@@ -2849,7 +2849,7 @@ static int ext4_writepages(struct address_space *mapping,
28492849
out_writepages:
28502850
trace_ext4_writepages_result(inode, wbc, ret,
28512851
nr_to_write - wbc->nr_to_write);
2852-
percpu_up_read(&sbi->s_journal_flag_rwsem);
2852+
percpu_up_read(&sbi->s_writepages_rwsem);
28532853
return ret;
28542854
}
28552855

@@ -2864,13 +2864,13 @@ static int ext4_dax_writepages(struct address_space *mapping,
28642864
if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
28652865
return -EIO;
28662866

2867-
percpu_down_read(&sbi->s_journal_flag_rwsem);
2867+
percpu_down_read(&sbi->s_writepages_rwsem);
28682868
trace_ext4_writepages(inode, wbc);
28692869

28702870
ret = dax_writeback_mapping_range(mapping, sbi->s_daxdev, wbc);
28712871
trace_ext4_writepages_result(inode, wbc, ret,
28722872
nr_to_write - wbc->nr_to_write);
2873-
percpu_up_read(&sbi->s_journal_flag_rwsem);
2873+
percpu_up_read(&sbi->s_writepages_rwsem);
28742874
return ret;
28752875
}
28762876

@@ -5861,7 +5861,7 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val)
58615861
}
58625862
}
58635863

5864-
percpu_down_write(&sbi->s_journal_flag_rwsem);
5864+
percpu_down_write(&sbi->s_writepages_rwsem);
58655865
jbd2_journal_lock_updates(journal);
58665866

58675867
/*
@@ -5878,15 +5878,15 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val)
58785878
err = jbd2_journal_flush(journal);
58795879
if (err < 0) {
58805880
jbd2_journal_unlock_updates(journal);
5881-
percpu_up_write(&sbi->s_journal_flag_rwsem);
5881+
percpu_up_write(&sbi->s_writepages_rwsem);
58825882
return err;
58835883
}
58845884
ext4_clear_inode_flag(inode, EXT4_INODE_JOURNAL_DATA);
58855885
}
58865886
ext4_set_aops(inode);
58875887

58885888
jbd2_journal_unlock_updates(journal);
5889-
percpu_up_write(&sbi->s_journal_flag_rwsem);
5889+
percpu_up_write(&sbi->s_writepages_rwsem);
58905890

58915891
if (val)
58925892
up_write(&EXT4_I(inode)->i_mmap_sem);

fs/ext4/super.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1064,7 +1064,7 @@ static void ext4_put_super(struct super_block *sb)
10641064
percpu_counter_destroy(&sbi->s_freeinodes_counter);
10651065
percpu_counter_destroy(&sbi->s_dirs_counter);
10661066
percpu_counter_destroy(&sbi->s_dirtyclusters_counter);
1067-
percpu_free_rwsem(&sbi->s_journal_flag_rwsem);
1067+
percpu_free_rwsem(&sbi->s_writepages_rwsem);
10681068
#ifdef CONFIG_QUOTA
10691069
for (i = 0; i < EXT4_MAXQUOTAS; i++)
10701070
kfree(get_qf_name(sb, sbi, i));
@@ -4626,7 +4626,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
46264626
err = percpu_counter_init(&sbi->s_dirtyclusters_counter, 0,
46274627
GFP_KERNEL);
46284628
if (!err)
4629-
err = percpu_init_rwsem(&sbi->s_journal_flag_rwsem);
4629+
err = percpu_init_rwsem(&sbi->s_writepages_rwsem);
46304630

46314631
if (err) {
46324632
ext4_msg(sb, KERN_ERR, "insufficient memory");
@@ -4726,7 +4726,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
47264726
percpu_counter_destroy(&sbi->s_freeinodes_counter);
47274727
percpu_counter_destroy(&sbi->s_dirs_counter);
47284728
percpu_counter_destroy(&sbi->s_dirtyclusters_counter);
4729-
percpu_free_rwsem(&sbi->s_journal_flag_rwsem);
4729+
percpu_free_rwsem(&sbi->s_writepages_rwsem);
47304730
failed_mount5:
47314731
ext4_ext_release(sb);
47324732
ext4_release_system_zone(sb);

0 commit comments

Comments
 (0)