Skip to content

Commit bc04441

Browse files
Xiu Jianfengsmfrench
authored andcommitted
ksmbd: Fix resource leak in ksmbd_session_rpc_open()
When ksmbd_rpc_open() fails then it must call ksmbd_rpc_id_free() to undo the result of ksmbd_ipc_id_alloc(). Fixes: e2f3448 ("cifsd: add server-side procedures for SMB3") Signed-off-by: Xiu Jianfeng <[email protected]> Acked-by: Namjae Jeon <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent 3042938 commit bc04441

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

fs/ksmbd/mgmt/user_session.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,17 @@ int ksmbd_session_rpc_open(struct ksmbd_session *sess, char *rpc_name)
108108
entry->method = method;
109109
entry->id = ksmbd_ipc_id_alloc();
110110
if (entry->id < 0)
111-
goto error;
111+
goto free_entry;
112112

113113
resp = ksmbd_rpc_open(sess, entry->id);
114114
if (!resp)
115-
goto error;
115+
goto free_id;
116116

117117
kvfree(resp);
118118
return entry->id;
119-
error:
119+
free_id:
120+
ksmbd_rpc_id_free(entry->id);
121+
free_entry:
120122
list_del(&entry->list);
121123
kfree(entry);
122124
return -EINVAL;

0 commit comments

Comments
 (0)