Skip to content

Commit bc8bd54

Browse files
johnstultz-workrobclark
authored andcommitted
drm/msm: Fix 0xfffflub in "Refactor address space initialization"
This week I started seeing GPU crashes on my DragonBoard 845c which I narrowed down to being caused by commit ccac7ce ("drm/msm: Refactor address space initialization"). Looking through the patch, Jordan and I couldn't find anything obviously wrong, so I ended up breaking that change up into a number of smaller logical steps so I could figure out which part was causing the trouble. Ends up, visually counting 'f's is hard, esp across a number of lines: 0xfffffff != 0xffffffff This patch corrects the end value we pass in to msm_gem_address_space_create() in adreno_iommu_create_address_space() so that it matches the value used before the problematic patch landed. With this change, I no longer see the GPU crashes that were affecting me. Cc: Shawn Guo <[email protected]> Cc: Rob Clark <[email protected]> Cc: Sean Paul <[email protected]> Cc: Jordan Crouse <[email protected]> Cc: [email protected] Fixes: ccac7ce ("drm/msm: Refactor address space initialization") Signed-off-by: John Stultz <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent 2e7ec6b commit bc8bd54

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/adreno/adreno_gpu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ adreno_iommu_create_address_space(struct msm_gpu *gpu,
194194
struct msm_gem_address_space *aspace;
195195

196196
aspace = msm_gem_address_space_create(mmu, "gpu", SZ_16M,
197-
0xfffffff);
197+
0xffffffff);
198198

199199
if (IS_ERR(aspace) && !IS_ERR(mmu))
200200
mmu->funcs->destroy(mmu);

0 commit comments

Comments
 (0)