Skip to content

Commit bcd0f93

Browse files
HBh25Ykuba-moo
authored andcommitted
phonet: refcount leak in pep_sock_accep
sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not invoked in subsequent failure branches(pep_accept_conn() != 0). Signed-off-by: Hangyu Hua <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent ab443c5 commit bcd0f93

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/phonet/pep.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -868,6 +868,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp,
868868

869869
err = pep_accept_conn(newsk, skb);
870870
if (err) {
871+
__sock_put(sk);
871872
sock_put(newsk);
872873
newsk = NULL;
873874
goto drop;

0 commit comments

Comments
 (0)