Skip to content

Commit bd21470

Browse files
bhadanednyaneshwarRadhakrishna Sripada
authored andcommitted
drm/i915/skl: s/SKL/SKYLAKE for platform/subplatform defines
Follow consistent naming convention. Replace SKL with SKYLAKE and Replace IS_SKL_GRAPHICS_STEP with IS_SKYLAKE() && IS_GRAPHICS_STEP(). v2: - Change subject skl instead of SKL(Anusha) v3: - Unrolled wrapper IS_SKL_GRAPHICS_STEP. - Replace with IS_PLATFORM && DISPLAY_STEP(tvrtko/jani) v4: - Removed the unused macro. Cc: Anusha Srivatsa <[email protected]> Signed-off-by: Dnyaneshwar Bhadane <[email protected]> Reviewed-by: Anusha Srivatsa <[email protected]> Acked-by: Jani Nikula <[email protected]> Signed-off-by: Radhakrishna Sripada <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent c224d89 commit bd21470

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1746,9 +1746,9 @@ void intel_ddi_buf_trans_init(struct intel_encoder *encoder)
17461746
encoder->get_buf_trans = kbl_u_get_buf_trans;
17471747
} else if (IS_COMETLAKE(i915) || IS_COFFEELAKE(i915) || IS_KABYLAKE(i915)) {
17481748
encoder->get_buf_trans = kbl_get_buf_trans;
1749-
} else if (IS_SKL_ULX(i915)) {
1749+
} else if (IS_SKYLAKE_ULX(i915)) {
17501750
encoder->get_buf_trans = skl_y_get_buf_trans;
1751-
} else if (IS_SKL_ULT(i915)) {
1751+
} else if (IS_SKYLAKE_ULT(i915)) {
17521752
encoder->get_buf_trans = skl_u_get_buf_trans;
17531753
} else if (IS_SKYLAKE(i915)) {
17541754
encoder->get_buf_trans = skl_get_buf_trans;

drivers/gpu/drm/i915/gt/intel_workarounds.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1192,7 +1192,7 @@ skl_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
11921192
GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
11931193

11941194
/* WaInPlaceDecompressionHang:skl */
1195-
if (IS_SKL_GRAPHICS_STEP(gt->i915, STEP_A0, STEP_H0))
1195+
if (IS_SKYLAKE(gt->i915) && IS_GRAPHICS_STEP(gt->i915, STEP_A0, STEP_H0))
11961196
wa_write_or(wal,
11971197
GEN9_GAMT_ECO_REG_RW_IA,
11981198
GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -608,19 +608,19 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
608608
/* ULX machines are also considered ULT. */
609609
#define IS_HASWELL_ULX(i915) \
610610
IS_SUBPLATFORM(i915, INTEL_HASWELL, INTEL_SUBPLATFORM_ULX)
611-
#define IS_SKL_ULT(i915) \
611+
#define IS_SKYLAKE_ULT(i915) \
612612
IS_SUBPLATFORM(i915, INTEL_SKYLAKE, INTEL_SUBPLATFORM_ULT)
613-
#define IS_SKL_ULX(i915) \
613+
#define IS_SKYLAKE_ULX(i915) \
614614
IS_SUBPLATFORM(i915, INTEL_SKYLAKE, INTEL_SUBPLATFORM_ULX)
615615
#define IS_KBL_ULT(i915) \
616616
IS_SUBPLATFORM(i915, INTEL_KABYLAKE, INTEL_SUBPLATFORM_ULT)
617617
#define IS_KBL_ULX(i915) \
618618
IS_SUBPLATFORM(i915, INTEL_KABYLAKE, INTEL_SUBPLATFORM_ULX)
619-
#define IS_SKL_GT2(i915) (IS_SKYLAKE(i915) && \
619+
#define IS_SKYLAKE_GT2(i915) (IS_SKYLAKE(i915) && \
620620
INTEL_INFO(i915)->gt == 2)
621-
#define IS_SKL_GT3(i915) (IS_SKYLAKE(i915) && \
621+
#define IS_SKYLAKE_GT3(i915) (IS_SKYLAKE(i915) && \
622622
INTEL_INFO(i915)->gt == 3)
623-
#define IS_SKL_GT4(i915) (IS_SKYLAKE(i915) && \
623+
#define IS_SKYLAKE_GT4(i915) (IS_SKYLAKE(i915) && \
624624
INTEL_INFO(i915)->gt == 4)
625625
#define IS_KBL_GT2(i915) (IS_KABYLAKE(i915) && \
626626
INTEL_INFO(i915)->gt == 2)
@@ -648,7 +648,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
648648
#define IS_TGL_UY(i915) \
649649
IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY)
650650

651-
#define IS_SKL_GRAPHICS_STEP(p, since, until) (IS_SKYLAKE(p) && IS_GRAPHICS_STEP(p, since, until))
652651

653652
#define IS_KBL_GRAPHICS_STEP(i915, since, until) \
654653
(IS_KABYLAKE(i915) && IS_GRAPHICS_STEP(i915, since, until))
@@ -799,7 +798,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
799798

800799
/* WaRsDisableCoarsePowerGating:skl,cnl */
801800
#define NEEDS_WaRsDisableCoarsePowerGating(i915) \
802-
(IS_SKL_GT3(i915) || IS_SKL_GT4(i915))
801+
(IS_SKYLAKE_GT3(i915) || IS_SKYLAKE_GT4(i915))
803802

804803
/* With the 945 and later, Y tiling got adjusted so that it was 32 128-byte
805804
* rows, which changed the alignment requirements and fence programming.

0 commit comments

Comments
 (0)