Skip to content

Commit bd50a97

Browse files
zijun-hugregkh
authored andcommitted
devres: Fix memory leakage caused by driver API devm_free_percpu()
It will cause memory leakage when use driver API devm_free_percpu() to free memory allocated by devm_alloc_percpu(), fixed by using devres_release() instead of devres_destroy() within devm_free_percpu(). Fixes: ff86aae ("devres: add devm_alloc_percpu()") Cc: [email protected] Signed-off-by: Zijun Hu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent c884e32 commit bd50a97

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/base/devres.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1225,7 +1225,11 @@ EXPORT_SYMBOL_GPL(__devm_alloc_percpu);
12251225
*/
12261226
void devm_free_percpu(struct device *dev, void __percpu *pdata)
12271227
{
1228-
WARN_ON(devres_destroy(dev, devm_percpu_release, devm_percpu_match,
1228+
/*
1229+
* Use devres_release() to prevent memory leakage as
1230+
* devm_free_pages() does.
1231+
*/
1232+
WARN_ON(devres_release(dev, devm_percpu_release, devm_percpu_match,
12291233
(__force void *)pdata));
12301234
}
12311235
EXPORT_SYMBOL_GPL(devm_free_percpu);

0 commit comments

Comments
 (0)