Skip to content

Commit bd5874d

Browse files
solbjorndavem330
authored andcommitted
net: dsa: tag_qca: fix doubled Tx statistics
DSA subsystem takes care of netdev statistics since commit 4ed70ce ("net: dsa: Refactor transmit path to eliminate duplication"), so any accounting inside tagger callbacks is redundant and can lead to messing up the stats. This bug is present in Qualcomm tagger since day 0. Fixes: cafdc45 ("net-next: dsa: add Qualcomm tag RX/TX handler") Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: Alexander Lobakin <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent ad32205 commit bd5874d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

net/dsa/tag_qca.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev)
3333
struct dsa_port *dp = dsa_slave_to_port(dev);
3434
u16 *phdr, hdr;
3535

36-
dev->stats.tx_packets++;
37-
dev->stats.tx_bytes += skb->len;
38-
3936
if (skb_cow_head(skb, 0) < 0)
4037
return NULL;
4138

0 commit comments

Comments
 (0)