Skip to content

Commit bd6f203

Browse files
avpatelpalmer-dabbelt
authored andcommitted
RISC-V: Only select essential drivers for SOC_VIRT config
The kconfig select causes build failues for SOC_VIRT config becaus we are selecting lot of VIRTIO drivers without selecting all required dependencies. Better approach is to only select essential drivers from SOC_VIRT config option and enable required VIRTIO drivers using defconfigs. Fixes: 759bdc1 ("RISC-V: Add kconfig option for QEMU virt machine") Signed-off-by: Anup Patel <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Palmer Dabbelt <[email protected]>
1 parent 3384b04 commit bd6f203

File tree

3 files changed

+30
-16
lines changed

3 files changed

+30
-16
lines changed

arch/riscv/Kconfig.socs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,6 @@ config SOC_SIFIVE
1212

1313
config SOC_VIRT
1414
bool "QEMU Virt Machine"
15-
select VIRTIO_PCI
16-
select VIRTIO_BALLOON
17-
select VIRTIO_MMIO
18-
select VIRTIO_CONSOLE
19-
select VIRTIO_NET
20-
select NET_9P_VIRTIO
21-
select VIRTIO_BLK
22-
select SCSI_VIRTIO
23-
select DRM_VIRTIO_GPU
24-
select HW_RANDOM_VIRTIO
25-
select RPMSG_CHAR
26-
select RPMSG_VIRTIO
27-
select CRYPTO_DEV_VIRTIO
28-
select VIRTIO_INPUT
2915
select POWER_RESET_SYSCON
3016
select POWER_RESET_SYSCON_POWEROFF
3117
select GOLDFISH

arch/riscv/configs/defconfig

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,23 @@ CONFIG_IP_PNP_BOOTP=y
3131
CONFIG_IP_PNP_RARP=y
3232
CONFIG_NETLINK_DIAG=y
3333
CONFIG_NET_9P=y
34+
CONFIG_NET_9P_VIRTIO=y
3435
CONFIG_PCI=y
3536
CONFIG_PCIEPORTBUS=y
3637
CONFIG_PCI_HOST_GENERIC=y
3738
CONFIG_PCIE_XILINX=y
3839
CONFIG_DEVTMPFS=y
3940
CONFIG_DEVTMPFS_MOUNT=y
4041
CONFIG_BLK_DEV_LOOP=y
42+
CONFIG_VIRTIO_BLK=y
4143
CONFIG_BLK_DEV_SD=y
4244
CONFIG_BLK_DEV_SR=y
45+
CONFIG_SCSI_VIRTIO=y
4346
CONFIG_ATA=y
4447
CONFIG_SATA_AHCI=y
4548
CONFIG_SATA_AHCI_PLATFORM=y
4649
CONFIG_NETDEVICES=y
50+
CONFIG_VIRTIO_NET=y
4751
CONFIG_MACB=y
4852
CONFIG_E1000E=y
4953
CONFIG_R8169=y
@@ -54,13 +58,16 @@ CONFIG_SERIAL_8250_CONSOLE=y
5458
CONFIG_SERIAL_OF_PLATFORM=y
5559
CONFIG_SERIAL_EARLYCON_RISCV_SBI=y
5660
CONFIG_HVC_RISCV_SBI=y
61+
CONFIG_VIRTIO_CONSOLE=y
5762
CONFIG_HW_RANDOM=y
63+
CONFIG_HW_RANDOM_VIRTIO=y
5864
CONFIG_SPI=y
5965
CONFIG_SPI_SIFIVE=y
6066
# CONFIG_PTP_1588_CLOCK is not set
6167
CONFIG_POWER_RESET=y
6268
CONFIG_DRM=y
6369
CONFIG_DRM_RADEON=y
70+
CONFIG_DRM_VIRTIO_GPU=y
6471
CONFIG_FRAMEBUFFER_CONSOLE=y
6572
CONFIG_USB=y
6673
CONFIG_USB_XHCI_HCD=y
@@ -74,6 +81,12 @@ CONFIG_USB_UAS=y
7481
CONFIG_MMC=y
7582
CONFIG_MMC_SPI=y
7683
CONFIG_RTC_CLASS=y
84+
CONFIG_VIRTIO_PCI=y
85+
CONFIG_VIRTIO_BALLOON=y
86+
CONFIG_VIRTIO_INPUT=y
87+
CONFIG_VIRTIO_MMIO=y
88+
CONFIG_RPMSG_CHAR=y
89+
CONFIG_RPMSG_VIRTIO=y
7790
CONFIG_EXT4_FS=y
7891
CONFIG_EXT4_FS_POSIX_ACL=y
7992
CONFIG_AUTOFS4_FS=y
@@ -88,16 +101,17 @@ CONFIG_NFS_V4_2=y
88101
CONFIG_ROOT_NFS=y
89102
CONFIG_9P_FS=y
90103
CONFIG_CRYPTO_USER_API_HASH=y
104+
CONFIG_CRYPTO_DEV_VIRTIO=y
91105
CONFIG_PRINTK_TIME=y
92106
CONFIG_DEBUG_FS=y
93107
CONFIG_DEBUG_PAGEALLOC=y
108+
CONFIG_SCHED_STACK_END_CHECK=y
94109
CONFIG_DEBUG_VM=y
95110
CONFIG_DEBUG_VM_PGFLAGS=y
96111
CONFIG_DEBUG_MEMORY_INIT=y
97112
CONFIG_DEBUG_PER_CPU_MAPS=y
98113
CONFIG_SOFTLOCKUP_DETECTOR=y
99114
CONFIG_WQ_WATCHDOG=y
100-
CONFIG_SCHED_STACK_END_CHECK=y
101115
CONFIG_DEBUG_TIMEKEEPING=y
102116
CONFIG_DEBUG_RT_MUTEXES=y
103117
CONFIG_DEBUG_SPINLOCK=y

arch/riscv/configs/rv32_defconfig

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,23 @@ CONFIG_IP_PNP_BOOTP=y
3131
CONFIG_IP_PNP_RARP=y
3232
CONFIG_NETLINK_DIAG=y
3333
CONFIG_NET_9P=y
34+
CONFIG_NET_9P_VIRTIO=y
3435
CONFIG_PCI=y
3536
CONFIG_PCIEPORTBUS=y
3637
CONFIG_PCI_HOST_GENERIC=y
3738
CONFIG_PCIE_XILINX=y
3839
CONFIG_DEVTMPFS=y
3940
CONFIG_DEVTMPFS_MOUNT=y
4041
CONFIG_BLK_DEV_LOOP=y
42+
CONFIG_VIRTIO_BLK=y
4143
CONFIG_BLK_DEV_SD=y
4244
CONFIG_BLK_DEV_SR=y
45+
CONFIG_SCSI_VIRTIO=y
4346
CONFIG_ATA=y
4447
CONFIG_SATA_AHCI=y
4548
CONFIG_SATA_AHCI_PLATFORM=y
4649
CONFIG_NETDEVICES=y
50+
CONFIG_VIRTIO_NET=y
4751
CONFIG_MACB=y
4852
CONFIG_E1000E=y
4953
CONFIG_R8169=y
@@ -54,11 +58,14 @@ CONFIG_SERIAL_8250_CONSOLE=y
5458
CONFIG_SERIAL_OF_PLATFORM=y
5559
CONFIG_SERIAL_EARLYCON_RISCV_SBI=y
5660
CONFIG_HVC_RISCV_SBI=y
61+
CONFIG_VIRTIO_CONSOLE=y
5762
CONFIG_HW_RANDOM=y
63+
CONFIG_HW_RANDOM_VIRTIO=y
5864
# CONFIG_PTP_1588_CLOCK is not set
5965
CONFIG_POWER_RESET=y
6066
CONFIG_DRM=y
6167
CONFIG_DRM_RADEON=y
68+
CONFIG_DRM_VIRTIO_GPU=y
6269
CONFIG_FRAMEBUFFER_CONSOLE=y
6370
CONFIG_USB=y
6471
CONFIG_USB_XHCI_HCD=y
@@ -70,6 +77,12 @@ CONFIG_USB_OHCI_HCD_PLATFORM=y
7077
CONFIG_USB_STORAGE=y
7178
CONFIG_USB_UAS=y
7279
CONFIG_RTC_CLASS=y
80+
CONFIG_VIRTIO_PCI=y
81+
CONFIG_VIRTIO_BALLOON=y
82+
CONFIG_VIRTIO_INPUT=y
83+
CONFIG_VIRTIO_MMIO=y
84+
CONFIG_RPMSG_CHAR=y
85+
CONFIG_RPMSG_VIRTIO=y
7386
CONFIG_EXT4_FS=y
7487
CONFIG_EXT4_FS_POSIX_ACL=y
7588
CONFIG_AUTOFS4_FS=y
@@ -84,16 +97,17 @@ CONFIG_NFS_V4_2=y
8497
CONFIG_ROOT_NFS=y
8598
CONFIG_9P_FS=y
8699
CONFIG_CRYPTO_USER_API_HASH=y
100+
CONFIG_CRYPTO_DEV_VIRTIO=y
87101
CONFIG_PRINTK_TIME=y
88102
CONFIG_DEBUG_FS=y
89103
CONFIG_DEBUG_PAGEALLOC=y
104+
CONFIG_SCHED_STACK_END_CHECK=y
90105
CONFIG_DEBUG_VM=y
91106
CONFIG_DEBUG_VM_PGFLAGS=y
92107
CONFIG_DEBUG_MEMORY_INIT=y
93108
CONFIG_DEBUG_PER_CPU_MAPS=y
94109
CONFIG_SOFTLOCKUP_DETECTOR=y
95110
CONFIG_WQ_WATCHDOG=y
96-
CONFIG_SCHED_STACK_END_CHECK=y
97111
CONFIG_DEBUG_TIMEKEEPING=y
98112
CONFIG_DEBUG_RT_MUTEXES=y
99113
CONFIG_DEBUG_SPINLOCK=y

0 commit comments

Comments
 (0)