Skip to content

Commit bd9e4d4

Browse files
jhovoldvinodkoul
authored andcommitted
phy: qcom: qmp-usb: fix NULL-deref on runtime suspend
Commit 413db06 ("phy: qcom-qmp-usb: clean up probe initialisation") removed most users of the platform device driver data, but mistakenly also removed the initialisation despite the data still being used in the runtime PM callbacks. Restore the driver data initialisation at probe to avoid a NULL-pointer dereference on runtime suspend. Apparently no one uses runtime PM, which currently needs to be enabled manually through sysfs, with this driver. Fixes: 413db06 ("phy: qcom-qmp-usb: clean up probe initialisation") Cc: [email protected] # 6.2 Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 938ade1 commit bd9e4d4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2179,6 +2179,7 @@ static int qmp_usb_probe(struct platform_device *pdev)
21792179
return -ENOMEM;
21802180

21812181
qmp->dev = dev;
2182+
dev_set_drvdata(dev, qmp);
21822183

21832184
qmp->cfg = of_device_get_match_data(dev);
21842185
if (!qmp->cfg)

0 commit comments

Comments
 (0)